-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix emphasis closing by single _ (part of left-flanking run) #1351
Conversation
fixes CommonMark: 456, 355, 451, 354, 356
Hi @RomanGotsiy thanks for the PR! It looks like the links to the demo have a slightly different input than what you put in this PR.
That being said, the fix the the link appears to work so I added a couple more reviewers. |
@styfle yes, updated the comment |
Thanks Roman! 🎉 |
Thanks for merging! |
No not yet. We could probably do a patch release soon. Keep an eye out for a release PR...it will probably be from @UziTech |
This seems to have caused a regression. Expected: https://spec.commonmark.org/dingus/?text=_foo_%2C%20_bar_ Should I open an issue? |
Yes please! And if you could determine which CommonMark test this is violating that would be helpful 😃 This PR added many more passing CM spec tests so there must be one in there we were ignoring and now regressed. |
Marked version:
0.5.1
Markdown flavor: CommonMark
Description
Fixes CommonMark: 456, 355, 451, 354, 356
Also, the concrete use case:
Expectation
CommonMark playground link)
Result
Marked playground link)
Contributor
Committer
In most cases, this should be a different person than the contributor.