show failing test when original tests takes > 1s #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Apr 17, 2018
test/index.js
Outdated
| @@ -198,6 +195,11 @@ function testFile(engine, file, filename, index) { | |||
| } | |||
| } | |||
|
|
|||
| if (elapsed[0] !== 0) { | |||
There was a problem hiding this comment.
I think this might be a little more clear if you used if (elapsed[0] > 0).
I wish we could use destructuring and do something like
var [ seconds, _ ] = elapsed;
if (seconds > 0) {}
``
styfle
reviewed
Apr 17, 2018
test/index.js
Outdated
| @@ -198,6 +195,11 @@ function testFile(engine, file, filename, index) { | |||
| } | |||
| } | |||
|
|
|||
| if (elapsed[0] !== 0) { | |||
| console.log(' failed because it took too long.\n\n passed in %dms', prettyElapsedTime(elapsed)); | |||
There was a problem hiding this comment.
Should console.log be console.error?
There was a problem hiding this comment.
none of the other calls are console.error I don't see any reason to change it.
styfle
approved these changes
Apr 17, 2018
|
@styfle: You caught me while I was updating the notes. lol |
|
@joshbruce Oops, did we lose something? |
|
@styfle: There's a slight chance we might have lost something in the Release Notes. I consolidated some, which may have been an area you were adding them to. Double-check?? |
|
@joshbruce They're all there 👍 |
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
This was referenced Mar 24, 2020
This was referenced Mar 31, 2020
This was referenced Apr 7, 2020
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
show failing test when original tests takes > 1s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 0.3.19
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.