Fix handling of adjacent lists.

An ordered list followed by an unordered list shouldn't be combined, even in non-smartLists mode. Should fix #530.
markedjs · Dec 6, 2018 · 58c8e75 · 58c8e75
1 parent ed64407
commit 58c8e75
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 2 deletions.
diff --git a/lib/marked.js b/lib/marked.js
@@ -355,9 +355,10 @@ Lexer.prototype.token = function(src, top) {
 
         // Determine whether the next list item belongs here.
         // Backpedal if it does not belong in this list.
-        if (this.options.smartLists && i !== l - 1) {
+        if (i !== l - 1) {
           b = block.bullet.exec(cap[i + 1])[0];
-          if (bull !== b && !(bull.length > 1 && b.length > 1)) {
+          if (bull.length > 1 ? b.length == 1
+              : (b.length > 1 || (this.options.smartLists && b !== bull))) {
             src = cap.slice(i + 1).join('\n') + src;
             i = l - 1;
           }

diff --git a/test/new/adjacent_lists.html b/test/new/adjacent_lists.html
@@ -0,0 +1,9 @@
+<ul>
+<li>This should be</li>
+<li>An unordered list</li>
+</ul>
+
+<ol>
+<li>This should be</li>
+<li>An unordered list</li>
+</ol>
diff --git a/test/new/adjacent_lists.text b/test/new/adjacent_lists.text
@@ -0,0 +1,5 @@
+* This should be
+* An unordered list
+
+1. This should be
+2. An unordered list
diff --git a/test/tests/adjacent_lists.html b/test/tests/adjacent_lists.html
@@ -0,0 +1,9 @@
+<ul>
+<li>This should be</li>
+<li>An unordered list</li>
+</ul>
+
+<ol>
+<li>This should be</li>
+<li>An unordered list</li>
+</ol>
diff --git a/test/tests/adjacent_lists.text b/test/tests/adjacent_lists.text
@@ -0,0 +1,5 @@
+* This should be
+* An unordered list
+
+1. This should be
+2. An unordered list