From 7b9995c5960eab6cba301070fc26a8d95a30aa27 Mon Sep 17 00:00:00 2001 From: vasilii Date: Wed, 27 Aug 2014 04:22:09 -0700 Subject: [PATCH] Revert "Track empty username and password in PasswordStore." This reverts https://codereview.chromium.org/493123002. There were too many generated crashes. BUG=407767 Review URL: https://codereview.chromium.org/512673002 Cr-Commit-Position: refs/heads/master@{#292134} --- .../password_manager/core/browser/login_database.cc | 9 --------- 1 file changed, 9 deletions(-) diff --git a/components/password_manager/core/browser/login_database.cc b/components/password_manager/core/browser/login_database.cc index e4efba909aa5..d9e6f09195ec 100644 --- a/components/password_manager/core/browser/login_database.cc +++ b/components/password_manager/core/browser/login_database.cc @@ -8,7 +8,6 @@ #include #include "base/bind.h" -#include "base/debug/dump_without_crashing.h" #include "base/files/file_path.h" #include "base/logging.h" #include "base/metrics/histogram.h" @@ -118,12 +117,6 @@ void AddCallback(int err, sql::Statement* /*stmt*/) { DLOG(WARNING) << "LoginDatabase::AddLogin updated an existing form"; } -// http://crbug.com/404012. Let's see where the empty fields come from. -void CheckForEmptyUsernameAndPassword(const PasswordForm& form) { - if (form.username_value.empty() && form.password_value.empty()) - base::debug::DumpWithoutCrashing(); -} - } // namespace LoginDatabase::LoginDatabase() { @@ -359,7 +352,6 @@ void LoginDatabase::ReportMetrics(const std::string& sync_username) { } PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) { - CheckForEmptyUsernameAndPassword(form); PasswordStoreChangeList list; std::string encrypted_password; if (EncryptedString(form.password_value, &encrypted_password) != @@ -403,7 +395,6 @@ PasswordStoreChangeList LoginDatabase::AddLogin(const PasswordForm& form) { } PasswordStoreChangeList LoginDatabase::UpdateLogin(const PasswordForm& form) { - CheckForEmptyUsernameAndPassword(form); std::string encrypted_password; if (EncryptedString(form.password_value, &encrypted_password) != ENCRYPTION_RESULT_SUCCESS)