Add better documentation notes to WithHTTPServer and WithStreamableHTTPServer

Yashwanth H L · Yashwanth H L · commit d9af8d763428 · 2025-05-29T17:01:17.000+05:30
diff --git a/server/sse.go b/server/sse.go
@@ -227,7 +227,9 @@ func WithSSEEndpoint(endpoint string) SSEOption {
 	}
 }
 
-// WithHTTPServer sets the HTTP server instance
+// WithHTTPServer sets the HTTP server instance.
+// NOTE: When providing a custom HTTP server, you must handle routing yourself
+// If routing is not set up, the server will start but won't handle any MCP requests.
 func WithHTTPServer(srv *http.Server) SSEOption {
 	return func(s *SSEServer) {
 		s.srv = srv
diff --git a/server/streamable_http.go b/server/streamable_http.go
@@ -73,7 +73,9 @@ func WithHTTPContextFunc(fn HTTPContextFunc) StreamableHTTPOption {
 	}
 }
 
-// WithStreamableHTTPServer sets the HTTP server instance for StreamableHTTPServer
+// WithStreamableHTTPServer sets the HTTP server instance for StreamableHTTPServer.
+// NOTE: When providing a custom HTTP server, you must handle routing yourself
+// If routing is not set up, the server will start but won't handle any MCP requests.
 func WithStreamableHTTPServer(srv *http.Server) StreamableHTTPOption {
 	return func(s *StreamableHTTPServer) {
 		s.httpServer = srv

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,9 @@ func WithSSEEndpoint(endpoint string) SSEOption {`
`227`	`227`	`}`
`228`	`228`	`}`
`229`	`229`
`230`		`-// WithHTTPServer sets the HTTP server instance`
	`230`	`+// WithHTTPServer sets the HTTP server instance.`
	`231`	`+// NOTE: When providing a custom HTTP server, you must handle routing yourself`
	`232`	`+// If routing is not set up, the server will start but won't handle any MCP requests.`
`231`	`233`	`func WithHTTPServer(srv *http.Server) SSEOption {`
`232`	`234`	`return func(s *SSEServer) {`
`233`	`235`	`s.srv = srv`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,9 @@ func WithHTTPContextFunc(fn HTTPContextFunc) StreamableHTTPOption {`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
`76`		`-// WithStreamableHTTPServer sets the HTTP server instance for StreamableHTTPServer`
	`76`	`+// WithStreamableHTTPServer sets the HTTP server instance for StreamableHTTPServer.`
	`77`	`+// NOTE: When providing a custom HTTP server, you must handle routing yourself`
	`78`	`+// If routing is not set up, the server will start but won't handle any MCP requests.`
`77`	`79`	`func WithStreamableHTTPServer(srv *http.Server) StreamableHTTPOption {`
`78`	`80`	`return func(s *StreamableHTTPServer) {`
`79`	`81`	`s.httpServer = srv`