Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for CoCreateGuid failure #46

Closed
stephenatwork opened this issue Sep 28, 2021 · 2 comments
Closed

Check for CoCreateGuid failure #46

stephenatwork opened this issue Sep 28, 2021 · 2 comments
Assignees
@mariusbancila
Labels
enhancement

Comments

@stephenatwork
Copy link

A static analysis tool has highlighted that the return HRESULT of CoCreateGuid is not checked.
It seems unlikley, but I guess we should check & throw?
@stephenatwork
Copy link
Author

Here's a suggested patch

system_error_patch.txt

@mariusbancila mariusbancila self-assigned this Dec 22, 2021
@mariusbancila
Copy link
Owner

Thanks for the suggestion. I've fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariusbancila mariusbancila

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenatwork @mariusbancila