Add "before:detach" / "detach" events?

[paulovieira]

#1957 adds the "before:attach"/"attach" events for the tree view that is placed in the DOM (using region's show). One common case for this event is to activate 3rd party plugins located deep in the view tree and that must be started only after the view is in the DOM.

Should we add "before:detach" / "detach" events as well? These might be necessary to shut down those plugins.

In principle it could (and should) be done on the view's "destroy". But if preventDestroy is true, beforeDestroy/destroy will not be fired.

[jamesplease]

This is a good idea. It should go in after #1925.

[jamesplease]

Also, I can take this one.

[samccone]

we chatted in chat about this one, an interesting side effect is that we are getting closer and closer to reacts DOM events :)

[stephanebachelier]

@jmeas Any news on this ?

[jamesplease]

Nope. I recall thinking at some point that #1925 landing first would make this easier, but I forget the specifics of why. My plan of attack was to work on #1925 first, but I've been busy.

[stephanebachelier]

@jmeas I was just asking :) I know you're busy while still doing lots of open source :)

[marcusstenbeck]

+1

I was looking for this functionality today.

[jasonLaster]

@ianmstew feel brave enough?

[ianmstew]

@jasonLaster Sure, I'll look into it.

[paulfalgout]

Closed by #2850