Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias Backbone objects on Marionette #1899

Closed
jamesplease opened this issue Sep 15, 2014 · 4 comments
Closed

Alias Backbone objects on Marionette #1899

jamesplease opened this issue Sep 15, 2014 · 4 comments

Comments

@jamesplease
Copy link
Member

Marionette.Model = Backbone.Model;
Marionette.Collection = Backbone.Collection;
Marionette.extend = Backbone.Model.extend;
Marionette.History = Backbone.History;
Marionette.history = Backbone.history;

Why not? This way people can just use the Marionette object and not even worry about Backbone.

This will tidy up people's code, and I think it makes Marionette feel more standalone, and less like an extension.

If we do this, we might also consider renaming Marionette.View to Marionette.BaseView, or something.

@samccone
Copy link
Member

This is confusing to me, but let me think on it I guess

@paulovieira
Copy link
Contributor

I don't think this is a good idea because it gives the impression that Marionette is extending Model and Collection as is doing for View. It might be confusing because people won't find anything about Marionette.Model in the docs (except that it is aliased).

Other downside is that it might cause incompatibilities with plugins that act on the Model/Collection department (the plugins might be expecting to have a reference to Backbone.Model).

@jamesplease
Copy link
Member Author

There should be more discussion about this, but for now it's going to the v3 doc.

#1796

@jamesplease
Copy link
Member Author

nvm i think this is a bad idea as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants