Skip to content

Commit c6c6bdd

Browse files
committed
Clarify default values of RT kernel config
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
1 parent 4de2d66 commit c6c6bdd

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

deploy/crds/performance.openshift.io_performanceprofiles_crd.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,11 @@ spec:
127127
type: object
128128
realTimeKernel:
129129
description: RealTimeKernel defines set of real time kernel related
130-
parameters.
130+
parameters. RT kernel won't be installed when not set.
131131
properties:
132132
enabled:
133133
description: Enabled defines if the real time kernel packages should
134-
be installed
134+
be installed. Defaults to "false"
135135
type: boolean
136136
type: object
137137
type: object

deploy/olm-catalog/performance-addon-operator/0.0.1/performance.openshift.io_performanceprofiles_crd.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -127,11 +127,11 @@ spec:
127127
type: object
128128
realTimeKernel:
129129
description: RealTimeKernel defines set of real time kernel related
130-
parameters.
130+
parameters. RT kernel won't be installed when not set.
131131
properties:
132132
enabled:
133133
description: Enabled defines if the real time kernel packages should
134-
be installed
134+
be installed. Defaults to "false"
135135
type: boolean
136136
type: object
137137
type: object

docs/performance_profile.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ PerformanceProfileSpec defines the desired state of PerformanceProfile.
114114
| machineConfigLabel | MachineConfigLabel defines the label to add to the MachineConfigs the operator creates. It has to be used in the MachineConfigSelector of the MachineConfigPool which targets this performance profile. Defaults to \"machineconfiguration.openshift.io/role=<same role as in NodeSelector label key>\" | map[string]string | false |
115115
| machineConfigPoolSelector | MachineConfigPoolSelector defines the MachineConfigPool label to use in the MachineConfigPoolSelector of resources like KubeletConfigs created by the operator. Defaults to \"machineconfiguration.openshift.io/role=<same role as in NodeSelector label key>\" | map[string]string | false |
116116
| nodeSelector | NodeSelector defines the Node label to use in the NodeSelectors of resources like Tuned created by the operator. It most likely should, but does not have to match the node label in the NodeSelector of the MachineConfigPool which targets this performance profile. | map[string]string | false |
117-
| realTimeKernel | RealTimeKernel defines set of real time kernel related parameters. | *[RealTimeKernel](#realtimekernel) | false |
117+
| realTimeKernel | RealTimeKernel defines set of real time kernel related parameters. RT kernel won't be installed when not set. | *[RealTimeKernel](#realtimekernel) | false |
118118
| additionalKernelArgs | Addional kernel arguments. | []string | false |
119119
| numa | NUMA defines options related to topology aware affinities | *[NUMA](#numa) | false |
120120

@@ -136,6 +136,6 @@ RealTimeKernel defines the set of parameters relevant for the real time kernel.
136136

137137
| Field | Description | Scheme | Required |
138138
| ----- | ----------- | ------ | -------- |
139-
| enabled | Enabled defines if the real time kernel packages should be installed | *bool | false |
139+
| enabled | Enabled defines if the real time kernel packages should be installed. Defaults to \"false\" | *bool | false |
140140

141141
[Back to TOC](#table-of-contents)

pkg/apis/performance/v1alpha1/performanceprofile_types.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ type PerformanceProfileSpec struct {
3131
// It most likely should, but does not have to match the node label in the NodeSelector of the MachineConfigPool
3232
// which targets this performance profile.
3333
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
34-
// RealTimeKernel defines set of real time kernel related parameters.
34+
// RealTimeKernel defines set of real time kernel related parameters. RT kernel won't be installed when not set.
3535
RealTimeKernel *RealTimeKernel `json:"realTimeKernel,omitempty"`
3636
// Addional kernel arguments.
3737
// +optional
@@ -96,7 +96,7 @@ type NUMA struct {
9696

9797
// RealTimeKernel defines the set of parameters relevant for the real time kernel.
9898
type RealTimeKernel struct {
99-
// Enabled defines if the real time kernel packages should be installed
99+
// Enabled defines if the real time kernel packages should be installed. Defaults to "false"
100100
Enabled *bool `json:"enabled,omitempty"`
101101
}
102102

0 commit comments

Comments
 (0)