-
Notifications
You must be signed in to change notification settings - Fork 10
Requirements not found error + fix for error in black #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
e67b5f3
53d752e
2f80fe2
f59a6e1
75802e7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: Install requirements from pipenv and lint all files | ||
on: | ||
pull_request: | ||
types: [ opened, reopened, synchronize, edited ] | ||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
name: Lint | ||
steps: | ||
- name: Check out source repository | ||
uses: actions/checkout@v3 | ||
- name: Set up Python environment | ||
uses: actions/setup-python@v3 | ||
with: | ||
python-version: "3.8" | ||
- name: Generate requirements.txt file | ||
run: | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm thinking if shouldn't just do this automatically? Check if the requirements file exists (provided by user). If not, install pipenv and generate dependencies. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you have time to do that then go ahead, but I don't |
||
pip install pipenv | ||
pipenv requirements > requirements.txt | ||
- uses: marian-code/python-lint-annotate@v3 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
black==21.11b1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We also need to update README file |
||
black~=22.3.0 | ||
flake8==4.0.1 | ||
isort==5.10.1 | ||
mypy~=0.961 | ||
pycodestyle==2.8.0 | ||
pydocstyle==6.1.1 | ||
pylint==2.12.1 | ||
vulture==2.3 | ||
vulture==2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup-python
'scache
argument was expecting a requirements.txt but is not doing the installSee the example in their readme file:
https://github.com/actions/setup-python#caching-packages-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, i have noticed this as well. Thanks for the fix