Escape U+2028 and U+2029 when writing JSON as a JavaScript string literal #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eral. U+2028 LINE SEPARATOR and U+2029 PARAGRAPH SEPARATOR are also not allowed in a JavaScript string literal. Trying to send a message with either would cause an "unexpected EOF" exception on the JavaScript side.
|
Are there any reservations to this? Or can I add anything that might help? |
|
Hey! Dude, sorry for the absent response! I am traveling and am not as responsive as usually. Github should have an "out of office, be back in June" auto-reply option :) Looks great, thanks for taking the time to PR and follow up. Cheers! |
marcuswestin
added a commit
that referenced
this pull request
Apr 29, 2014
Escape U+2028 and U+2029 when writing JSON as a JavaScript string literal
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
U+2028 LINE SEPARATOR and U+2029 PARAGRAPH SEPARATOR are not allowed in a JavaScript string literal, though they are valid JSON. Trying to send a message with either causes an "unexpected EOF" exception on the JavaScript side. Here's a relevant blog post on the issue.
You can test this by doing something like
[_bridge send:@"A string sent\u2028 from ObjC to JS" responseCallback:nil].