prevent insert nil into NSDictionary #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's what I want! |
|
It's awesome! |
|
cool |
|
Hey guys, I'm sorry I've been absent on this one. Would it make more sense to send an NSNull value? |
|
Yes, of course. there are many scenarios we pass nil in, so I think the BRIDGE should handle this case. |
|
Cool, thanks guys, sorry for the delay. I am going to merge the patch and then change the replacement value from |
marcuswestin
added a commit
that referenced
this pull request
May 23, 2014
prevent insert nil into NSDictionary
marcuswestin
added a commit
that referenced
this pull request
May 23, 2014
…replace that value with `[NSNull null]` instead of `@{}`. This way the javascript will receive a `null` value instead of `{}`. See gh pr #73
|
It's perfect, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent potential crash when sending
nilas responseData.