Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a WebViewJavascriptBridgeDelegate #70

Merged
merged 1 commit into from
May 22, 2014
Merged

create a WebViewJavascriptBridgeDelegate #70

merged 1 commit into from
May 22, 2014

Conversation

shuizhongyueming
Copy link
Contributor

make the user can decide whether the request from webview should be load except the WVJB request

@marcuswestin
Copy link
Owner

Cool! I need to take a look at massage it a little bit, hopefully this weekend. Otherwise it looks good. Thanks for the patch!

@shuizhongyueming
Copy link
Contributor Author

I was just need it in my project, so I hope this can be useful to others

marcuswestin added a commit that referenced this pull request May 22, 2014
@marcuswestin
Merge pull request #70 from shuizhongyueming/master
49579d6 
create a WebViewJavascriptBridgeDelegate
@marcuswestin marcuswestin merged commit 49579d6 into marcuswestin:master May 22, 2014
@marcuswestin
Copy link
Owner

Sorry this took forever :( Have been traveling since February.

marcuswestin added a commit that referenced this pull request May 22, 2014
@marcuswestin
Revert "Merge pull request #70 from shuizhongyueming/master"
6da9284 
This reverts commit 49579d6, reversing
changes made to 18b51d2.

The added changes only worked for iOS projects, but broke OSX builds.
@marcuswestin
Copy link
Owner

Hey, sorry, I had to revert this. It breaks OSX builds. If you want to make it work in OSX as well I'll consider merging it again, but it probable needs to find a better way to fit into the current API constructor methods as well.

Cheers.

@shuizhongyueming
Copy link
Contributor Author

sorry for that, I'm not good at developing in OSX

@marcuswestin
Copy link
Owner

No worries. If you want to give it a go, just open up the example OSX xcode
project and run it. It should just work. Maybe it'll be fun for you to play
with an OSX app as well? :)

On Fri, May 23, 2014 at 6:28 AM, happy wang notifications@github.comwrote:

sorry for that, I'm not good at developing in OSX

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/70#issuecomment-43970232
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuizhongyueming @marcuswestin