Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serious bug for WebViewJavascriptBridge #86

Closed
cherishloveyou opened this issue Jun 19, 2014 · 7 comments
Closed

serious bug for WebViewJavascriptBridge #86

cherishloveyou opened this issue Jun 19, 2014 · 7 comments

Comments

@cherishloveyou
Copy link

After load a url,the webViewDidFinishLoad called twice each time! And the webview.isLoading always is YES. In my opinion,It's error,because the page have been loaded, why it is still isLoading? can anyone explain it?

marcuswestin added a commit that referenced this issue Jun 28, 2014
…M. This fixes the problems described in github issue #86, where webViewDidStart/FinishLoad were called twice and isLoading was always true.
@marcuswestin
Copy link
Owner

Hey @cherishloveyou, thanks for taking the time to write about this. It should be fixed in master.

@pushpak
Copy link
Contributor

pushpak commented Jun 28, 2014

i think we should get a new release 4.1.2 for this with updated podfile 👍

@marcuswestin
Copy link
Owner

Yes, will do. Give me a day or two. I have too much sun and beer at the moment to bother.-- while mobile

On Sat, Jun 28, 2014 at 4:45 PM, Pushpak notifications@github.com wrote:

i think we should get a new release 4.1.2 for this with updated podfile 👍

Reply to this email directly or view it on GitHub:
#86 (comment)

@marcuswestin
Copy link
Owner

v4.1.2 tagged, podfile updated. I forget, do I need to do something else after I've updated the podfile?

@pushpak
Copy link
Contributor

pushpak commented Jun 30, 2014

you need to push the updated podfile to the cocoapod repo

On Tue, Jul 1, 2014 at 12:18 AM, Marcus Westin notifications@github.com
wrote:

v4.1.2 tagged, podfile updated. I forget, do I need to do something else
after I've updated the podfile?


Reply to this email directly or view it on GitHub
#86 (comment)
.

Regards,

Pushpak Rangaiah

Co-Founder and CEO

Shoptree, Inc.

Shoptree is cloud based easy-to-use point-of-sale, inventory and customer
management software to help grow your business. http://www.shoptreeapp.com
http://www.shoptreeapp.com/

@marcuswestin
Copy link
Owner

Pushpak: is this something you can do? I've never done it in the pasts myself, so I'm pretty confident anyone can do it.-- while mobile

On Mon, Jun 30, 2014 at 2:51 PM, Pushpak notifications@github.com wrote:

you need to push the updated podfile to the cocoapod repo
On Tue, Jul 1, 2014 at 12:18 AM, Marcus Westin notifications@github.com
wrote:

v4.1.2 tagged, podfile updated. I forget, do I need to do something else
after I've updated the podfile?


Reply to this email directly or view it on GitHub
#86 (comment)
.

Regards,
Pushpak Rangaiah
Co-Founder and CEO
Shoptree, Inc.
Shoptree is cloud based easy-to-use point-of-sale, inventory and customer
management software to help grow your business. http://www.shoptreeapp.com

http://www.shoptreeapp.com/

Reply to this email directly or view it on GitHub:
#86 (comment)

@marcuswestin
Copy link
Owner

I'd also happily accept a PR with a script that automates this process.-- while mobile

On Mon, Jun 30, 2014 at 2:51 PM, Pushpak notifications@github.com wrote:

you need to push the updated podfile to the cocoapod repo
On Tue, Jul 1, 2014 at 12:18 AM, Marcus Westin notifications@github.com
wrote:

v4.1.2 tagged, podfile updated. I forget, do I need to do something else
after I've updated the podfile?


Reply to this email directly or view it on GitHub
#86 (comment)
.

Regards,
Pushpak Rangaiah
Co-Founder and CEO
Shoptree, Inc.
Shoptree is cloud based easy-to-use point-of-sale, inventory and customer
management software to help grow your business. http://www.shoptreeapp.com

http://www.shoptreeapp.com/

Reply to this email directly or view it on GitHub:
#86 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants