-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a task progress indicator to notes in board view #897
base: main
Are you sure you want to change the base?
Conversation
Instead of going through note content to get the tasks, if we only want to get the progress, we can read it directly from metadata cache if I remembered correctly. Will commit. |
Yeah directly commit on this is fine! I'm rewriting |
const completedTasks = taskLines.map(l => COMPLETED_ITEM_REGEX.test(l)).filter(Boolean).length; | ||
const totalTasks = app.metadataCache | ||
.getFileCache(file) | ||
?.listItems?.filter((item) => item.task !== undefined); | ||
|
||
if (totalTasks) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totalTasks
is an empty array in the present cache but no tasks case; empty arrays are true
in js. Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We're now handling "tasks" in multiple levels. The existing "total" was introduced to show the progress of the whole column, working alongwith a However, when talking about "weight", it becomes a little bit confusing. Projects once used the term Then, regarding the idea of "allow a task contribute more to the total", I suggest that we directly adapt terms from scrum / sprint, like |
Smaller icon
Hmm, I see the confusion. I didn't intend for task progress icons to have anything to do with actual task completion or task closing - perhaps "task progress" is a misnomer, "step completion" or simply "checklist items" (this is what Trello uses) might be a better choice. This is semantic since we never actually use the title of this feature anywhere. But the point is, I agree that the task in the board is atomic, but I also allow that it may be composed of several discrete steps to complete - and this icon tracks that progress. I'm also against multiple leves of task handling - the task structure should be as flat as possible. I'm also not against renaming "task weight" to "task/story point value", in my experience the two are equally established agile terms I suggest:
|
also show all point values instead of only >1
Quick implementation of a feature I've been missing from projects - a Trello-style checkbox task progress indicator in Board view
A note with something like this:
automatically gains this indicator:
Let me know if this is something that will benefit projects, and if you'd like anything more fleshed out (eg, a plugin setting to enable this functionality, etc), I'd be happy to work on this further.
Perhaps this should be a custom field/record value, so it can be used for filtering/sorting/coloring.