Skip to content

Commit

Permalink
Remove android_webview_build conditions from various places.
Browse files Browse the repository at this point in the history
Remove various minor android_webview_build references now that we no
longer support that build configuration.

BUG=440793

Review URL: https://codereview.chromium.org/1048863002

Cr-Commit-Position: refs/heads/master@{#324078}
  • Loading branch information
tornewuff authored and Commit bot committed Apr 7, 2015
1 parent 36b9038 commit fe8398d
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 32 deletions.
4 changes: 1 addition & 3 deletions media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,10 @@ component("media") {
]
deps += [
"//media/base/android",
"//media/base/android:media_java",
"//media/base/android:media_jni_headers",
"//media/base/android:video_capture_jni_headers",
]
if (!is_android_webview_build) {
deps += [ "//media/base/android:media_java" ]
}
}

if (current_cpu != "arm" && is_chromeos) {
Expand Down
8 changes: 1 addition & 7 deletions media/media.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -713,6 +713,7 @@
['OS=="android"', {
'dependencies': [
'media_android_jni_headers',
'media_java',
'player_android',
'video_capture_android_jni_headers',
],
Expand All @@ -727,13 +728,6 @@
'renderers/default_renderer_factory.cc',
'renderers/default_renderer_factory.h',
],
'conditions': [
['android_webview_build==0', {
'dependencies': [
'media_java',
],
}],
],
'defines': [
'DISABLE_USER_INPUT_MONITOR',
],
Expand Down
5 changes: 1 addition & 4 deletions net/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -507,10 +507,7 @@ component("net") {
"base/platform_mime_util_linux.cc",
]
set_sources_assignment_filter(sources_assignment_filter)

if (!is_android_webview_build) {
deps += [ ":net_jni_headers" ]
}
deps += [ ":net_jni_headers" ]
}

if (use_icu_alternatives_on_android) {
Expand Down
2 changes: 1 addition & 1 deletion net/net_common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@
],
},
],
['OS=="android" and _toolset=="target" and android_webview_build == 0', {
['OS=="android" and _toolset=="target"', {
'dependencies': [
'net_java',
],
Expand Down
7 changes: 0 additions & 7 deletions skia/skia_common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,6 @@
'SK_ARM_HAS_OPTIONAL_NEON',
],
}],

# Enable feedback-directed optimisation for skia when building in android.
[ 'android_webview_build == 1', {
'aosp_build_settings': {
'LOCAL_FDO_SUPPORT': 'true',
},
}],
],

'variables': {
Expand Down
6 changes: 0 additions & 6 deletions third_party/sqlite/sqlite.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,6 @@
'-Wno-pointer-to-int-cast',
],
}],
# Enable feedback-directed optimisation for sqlite when building in android.
['android_webview_build == 1', {
'aosp_build_settings': {
'LOCAL_FDO_SUPPORT': 'true',
},
}],
],
}],
],
Expand Down
5 changes: 1 addition & 4 deletions tools/imagediff/image_diff.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,11 @@
'image_diff_png.cc',
],
'conditions': [
['OS=="android" and android_webview_build==0', {
['OS=="android"', {
# The Chromium Android port will compare images on host rather
# than target (a device or emulator) for performance reasons.
'toolsets': ['host'],
}],
['OS=="android" and android_webview_build==1', {
'type': 'none',
}],
],
},
],
Expand Down

0 comments on commit fe8398d

Please sign in to comment.