Add Earl Grey tests for ContentSuggestions

Adds a test for checking that the privacy settings for
ContentSuggestions is available.
Also add a test to check that the section titles are displayed only
when there are two sections.

Bug: 749981
Change-Id: I4b6289b57c26dadb2db5ae7a540ac3adf01ce58a
Reviewed-on: https://chromium-review.googlesource.com/605807
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492917}

ios/chrome/browser/ui/content_suggestions/BUILD.gn

@@ -96,7 +96,9 @@ source_set("eg_tests") {
     "//base/test:test_support",
     "//components/keyed_service/ios",
     "//components/ntp_snippets",
+    "//components/ntp_snippets:test_support",
     "//components/reading_list/core",
+    "//components/strings",
     "//ios/chrome/app/strings",
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",
@@ -110,6 +112,7 @@ source_set("eg_tests") {
     "//ios/testing/earl_grey:earl_grey_support",
     "//ios/third_party/earl_grey",
     "//ios/web/public/test/http_server",
+    "//testing/gmock",
     "//ui/strings",
   ]
   libs = [

ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm

@@ -5,11 +5,19 @@
 #import <EarlGrey/EarlGrey.h>
 #import <XCTest/XCTest.h>
 
+#include <vector>
+
+#include "base/mac/foundation_util.h"
+#include "base/memory/ptr_util.h"
+#include "base/strings/utf_string_conversions.h"
 #include "base/test/scoped_command_line.h"
 #include "components/keyed_service/ios/browser_state_keyed_service_factory.h"
+#include "components/ntp_snippets/content_suggestion.h"
 #include "components/ntp_snippets/content_suggestions_service.h"
+#include "components/ntp_snippets/mock_content_suggestions_provider.h"
 #include "components/reading_list/core/reading_list_entry.h"
 #include "components/reading_list/core/reading_list_model.h"
+#include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/browser_state/chrome_browser_state.h"
 #include "ios/chrome/browser/chrome_switches.h"
 #include "ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.h"
@@ -28,14 +36,28 @@
 #import "ios/chrome/test/earl_grey/chrome_test_case.h"
 #import "ios/web/public/test/http_server/http_server.h"
 #include "ios/web/public/test/http_server/http_server_util.h"
+#include "testing/gmock/include/gmock/gmock.h"
 #include "ui/strings/grit/ui_strings.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
+using namespace ntp_snippets;
+
 namespace {
 
+// Returns a suggestion created from the |category|, |suggestion_id| and the
+// |url|.
+ContentSuggestion Suggestion(Category category,
+                             std::string suggestion_id,
+                             GURL url) {
+  ContentSuggestion suggestion(category, suggestion_id, url);
+  suggestion.set_title(base::UTF8ToUTF16(url.spec()));
+
+  return suggestion;
+}
+
 // Select the cell with the |matcher| by scrolling the collection.
 // 150 is a reasonable scroll displacement that works for all UI elements, while
 // not being too slow.
@@ -48,15 +70,64 @@
                                [ContentSuggestionsViewController
                                    collectionAccessibilityIdentifier])];
 }
+
+}  // namespace
+
+// Singleton allowing to register the provider in the +setup and still access it
+// from inside the tests.
+@interface ContentSuggestionsTestSingleton : NSObject
+
+// Shared instance of this singleton.
++ (instancetype)sharedInstance;
+
+// Returns the provider registered.
+- (MockContentSuggestionsProvider*)provider;
+// Registers a provider in the |service|.
+- (void)registerArticleProvider:(ContentSuggestionsService*)service;
+
+@end
+
+@implementation ContentSuggestionsTestSingleton {
+  MockContentSuggestionsProvider* _provider;
 }
 
++ (instancetype)sharedInstance {
+  static ContentSuggestionsTestSingleton* sharedInstance = nil;
+  static dispatch_once_t onceToken;
+  dispatch_once(&onceToken, ^{
+    sharedInstance = [[self alloc] init];
+  });
+  return sharedInstance;
+}
+
+- (MockContentSuggestionsProvider*)provider {
+  return _provider;
+}
+
+- (void)registerArticleProvider:(ContentSuggestionsService*)service {
+  Category articles = Category::FromKnownCategory(KnownCategories::ARTICLES);
+  std::unique_ptr<MockContentSuggestionsProvider> provider =
+      base::MakeUnique<MockContentSuggestionsProvider>(
+          service, std::vector<Category>{articles});
+  _provider = provider.get();
+  service->RegisterProvider(std::move(provider));
+}
+
+@end
+
+#pragma mark - TestCase
+
 // Test case for the ContentSuggestion UI.
 @interface ContentSuggestionsTestCase : ChromeTestCase {
   base::test::ScopedCommandLine _scopedCommandLine;
 }
 
 // Current non-incognito browser state.
 @property(nonatomic, assign, readonly) ios::ChromeBrowserState* browserState;
+// Mock provider from the singleton.
+@property(nonatomic, assign, readonly) MockContentSuggestionsProvider* provider;
+// Article category, used by the singleton.
+@property(nonatomic, assign, readonly) Category category;
 
 @end
 
@@ -74,12 +145,14 @@ + (void)setUp {
   // service with no provider registered, allowing to register fake providers
   // which do not require internet connection. The previous service is deleted.
   IOSChromeContentSuggestionsServiceFactory::GetInstance()->SetTestingFactory(
-      browserState, ntp_snippets::CreateChromeContentSuggestionsService);
+      browserState, CreateChromeContentSuggestionsService);
 
-  ntp_snippets::RegisterReadingListProvider(
+  ContentSuggestionsService* service =
       IOSChromeContentSuggestionsServiceFactory::GetForBrowserState(
-          browserState),
-      browserState);
+          browserState);
+  RegisterReadingListProvider(service, browserState);
+  [[ContentSuggestionsTestSingleton sharedInstance]
+      registerArticleProvider:service];
 }
 
 + (void)tearDown {
@@ -91,25 +164,66 @@ + (void)tearDown {
   // Resets the Service associated with this browserState to a service with
   // default providers. The previous service is deleted.
   IOSChromeContentSuggestionsServiceFactory::GetInstance()->SetTestingFactory(
-      browserState,
-      ntp_snippets::CreateChromeContentSuggestionsServiceWithProviders);
+      browserState, CreateChromeContentSuggestionsServiceWithProviders);
   [super tearDown];
 }
 
-#pragma mark - Tests
-
 - (void)setUp {
   // The command line is set up before [super setUp] in order to have the NTP
   // opened with the command line already setup.
   base::CommandLine* commandLine = _scopedCommandLine.GetProcessCommandLine();
   commandLine->AppendSwitch(switches::kEnableSuggestionsUI);
+  self.provider->FireCategoryStatusChanged(self.category,
+                                           CategoryStatus::AVAILABLE);
 
   ReadingListModel* readingListModel =
       ReadingListModelFactory::GetForBrowserState(self.browserState);
   readingListModel->DeleteAllEntries();
   [super setUp];
 }
 
+- (void)tearDown {
+  self.provider->FireCategoryStatusChanged(
+      self.category, CategoryStatus::ALL_SUGGESTIONS_EXPLICITLY_DISABLED);
+  [super tearDown];
+}
+
+#pragma mark - Tests
+
+// Tests that a switch for the ContentSuggestions exists in the settings. The
+// behavior depends on having a real remote provider, so it cannot be tested
+// here.
+- (void)testPrivacySwitch {
+  [ChromeEarlGreyUI openSettingsMenu];
+  [ChromeEarlGreyUI
+      tapSettingsMenuButton:chrome_test_util::SettingsMenuPrivacyButton()];
+  [[EarlGrey selectElementWithMatcher:
+                 chrome_test_util::StaticTextWithAccessibilityLabelId(
+                     IDS_IOS_OPTIONS_CONTENT_SUGGESTIONS)]
+      assertWithMatcher:grey_sufficientlyVisible()];
+}
+
+// Tests that the section titles are displayed only if there are two sections.
+- (void)testSectionTitle {
+  ReadingListModel* readingListModel =
+      ReadingListModelFactory::GetForBrowserState(self.browserState);
+  readingListModel->AddEntry(GURL("http://chromium.org"), "test title",
+                             reading_list::ADDED_VIA_CURRENT_APP);
+
+  [CellWithMatcher(chrome_test_util::StaticTextWithAccessibilityLabelId(
+      IDS_NTP_READING_LIST_SUGGESTIONS_SECTION_HEADER))
+      assertWithMatcher:grey_nil()];
+
+  std::vector<ContentSuggestion> suggestions;
+  suggestions.emplace_back(
+      Suggestion(self.category, "chromium", GURL("http://chromium.org")));
+  self.provider->FireSuggestionsChanged(self.category, std::move(suggestions));
+
+  [CellWithMatcher(chrome_test_util::StaticTextWithAccessibilityLabelId(
+      IDS_NTP_READING_LIST_SUGGESTIONS_SECTION_HEADER))
+      assertWithMatcher:grey_sufficientlyVisible()];
+}
+
 // Tests that the "Learn More" cell is present.
 - (void)testLearnMore {
   [CellWithMatcher(grey_accessibilityID(
@@ -204,4 +318,12 @@ - (void)testMostVisitedLongPress {
   return chrome_test_util::GetOriginalBrowserState();
 }
 
+- (MockContentSuggestionsProvider*)provider {
+  return [[ContentSuggestionsTestSingleton sharedInstance] provider];
+}
+
+- (Category)category {
+  return Category::FromKnownCategory(KnownCategories::ARTICLES);
+}
+
 @end