forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Deflake color tests by lazily printing test results (3x faster)
The color parser tests are slow because they have an O(n^2) pattern of measuring elements in the page, then adding test results to the page in a loop. This loop gets slower over time as the measurement step needs to re-measure more and more elements. This patch adds some experimental logic to js-test.js for lazily printing test results. If this pans out we can investigate enabling this by default for all js-tests. Before patch: css-parser/color3.html - 326ms css-parser/color3_hsl.html - 2344ms css-parser/color3_hsla_1.html - 3668ms css-parser/color3_hsla_2.html - 3765ms css-parser/color3_keywords.html - 1897ms With patch: css-parser/color3.html - 138ms css-parser/color3_hsl.html - 718ms css-parser/color3_hsla_1.html - 1071ms css-parser/color3_hsla_2.html - 1124ms css-parser/color3_keywords.html - 616ms TBR=leviw BUG=435733 Review URL: https://codereview.chromium.org/752993002 git-svn-id: svn://svn.chromium.org/blink/trunk@185924 bbb929c8-8fbe-4397-9dbb-9b2b20218538
- Loading branch information
Showing
3 changed files
with
35 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters