Skip to content

Commit

Permalink
Move mojo edk into mojo/edk
Browse files Browse the repository at this point in the history
This creates a mojo/edk directory which contains the "embedder developer
kit" aka the set of code needed to embed mojo code.

mojo/edk/embedder = code from mojo/embedder
mojo/edk/system = code from mojo/system
mojo/edk/test = code used to test the previous two, from mojo/common/test

mojo/edk/ can only depend on mojo/public/, base/ and itself.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/621153003

Cr-Commit-Position: refs/heads/master@{#297958}
  • Loading branch information
jamesr committed Oct 3, 2014
1 parent 20894f5 commit ee7ff19
Show file tree
Hide file tree
Showing 199 changed files with 820 additions and 813 deletions.
2 changes: 1 addition & 1 deletion chrome/browser/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,10 @@ static_library("browser") {
"//content/app/resources",
"//media",
"//media/cast:net",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/public/cpp/bindings",
"//mojo/public/js/bindings",
"//mojo/system",
"//net:extras",
"//net:net_with_v8",
"//storage/browser",
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/ui/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ static_library("ui") {
"//device/bluetooth",
"//device/nfc",
"//media",
"//mojo/system",
"//mojo/edk/system",
"//net:net_with_v8",
"//storage/browser",
"//storage/common",
Expand Down
2 changes: 1 addition & 1 deletion chrome/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ source_set("test_support_unit") {
"//chrome:strings",
"//chrome/browser",
"//chrome/common",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/system",
]
}
2 changes: 1 addition & 1 deletion chrome/test/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ include_rules = [
"+gin/public",
"+grit", # For generated headers. TODO(thestig): Remove.
"+media/base",
"+mojo/embedder",
"+mojo/edk/embedder",
"+sandbox/win/tests",
"+win8/test",
]
2 changes: 1 addition & 1 deletion chrome/test/base/run_all_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include "base/test/launcher/unit_test_launcher.h"
#include "chrome/test/base/chrome_unit_test_suite.h"
#include "content/public/test/unittest_test_suite.h"
#include "mojo/embedder/test_embedder.h"
#include "mojo/edk/embedder/test_embedder.h"

int main(int argc, char **argv) {
content::UnitTestTestSuite test_suite(new ChromeUnitTestSuite(argc, argv));
Expand Down
2 changes: 1 addition & 1 deletion content/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ include_rules = [
"+mojo/application_manager",
"+mojo/bindings/js",
"+mojo/common",
"+mojo/embedder",
"+mojo/edk/embedder",
"+mojo/public",
"+net",
"+ppapi",
Expand Down
2 changes: 1 addition & 1 deletion content/app/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ if (is_ios) {
} else {
content_app_deps += [
"//mojo/application_manager",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/public/interfaces/application",
"//mojo/system",
]
}

Expand Down
4 changes: 2 additions & 2 deletions content/app/mojo/mojo_init.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#include "content/app/mojo/mojo_init.h"

#include "base/memory/scoped_ptr.h"
#include "mojo/embedder/embedder.h"
#include "mojo/embedder/simple_platform_support.h"
#include "mojo/edk/embedder/embedder.h"
#include "mojo/edk/embedder/simple_platform_support.h"

namespace content {

Expand Down
2 changes: 1 addition & 1 deletion content/browser/mojo/mojo_application_host.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include "content/common/mojo/mojo_messages.h"
#include "content/public/browser/browser_thread.h"
#include "ipc/ipc_sender.h"
#include "mojo/embedder/platform_channel_pair.h"
#include "mojo/edk/embedder/platform_channel_pair.h"

namespace content {
namespace {
Expand Down
4 changes: 2 additions & 2 deletions content/browser/mojo/mojo_application_host.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@

#include "base/process/process_handle.h"
#include "content/common/mojo/service_registry_impl.h"
#include "mojo/embedder/channel_init.h"
#include "mojo/embedder/scoped_platform_handle.h"
#include "mojo/edk/embedder/channel_init.h"
#include "mojo/edk/embedder/scoped_platform_handle.h"

namespace IPC {
class Sender;
Expand Down
2 changes: 1 addition & 1 deletion content/browser/webui/web_ui_mojo_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
#include "content/public/test/content_browser_test_utils.h"
#include "content/shell/browser/shell.h"
#include "content/test/data/web_ui_test_mojo_bindings.mojom.h"
#include "mojo/common/test/test_utils.h"
#include "mojo/edk/test/test_utils.h"
#include "mojo/public/cpp/bindings/interface_impl.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/public/js/bindings/constants.h"
Expand Down
2 changes: 1 addition & 1 deletion content/child/mojo/mojo_application.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#include "content/common/mojo/service_registry_impl.h"
#include "ipc/ipc_platform_file.h"
#include "mojo/embedder/channel_init.h"
#include "mojo/edk/embedder/channel_init.h"

namespace IPC {
class Message;
Expand Down
2 changes: 1 addition & 1 deletion content/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ source_set("common") {
"//gpu/skia_bindings",
"//media",
"//media:shared_memory_support",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/public/interfaces/application",
"//mojo/system",
"//sandbox",
"//storage/browser",
"//storage/common",
Expand Down
2 changes: 1 addition & 1 deletion device/test/DEPS
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
include_rules = [
"+mojo/embedder",
"+mojo/edk/embedder",
"+net/proxy",
"+net/url_request",
]
2 changes: 1 addition & 1 deletion device/test/run_all_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "base/bind.h"
#include "base/test/launcher/unit_test_launcher.h"
#include "base/test/test_suite.h"
#include "mojo/embedder/test_embedder.h"
#include "mojo/edk/embedder/test_embedder.h"

int main(int argc, char** argv) {
base::TestSuite test_suite(argc, argv);
Expand Down
4 changes: 2 additions & 2 deletions extensions/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,10 @@ test("unittests") {
"//extensions/common",
"//extensions/renderer",
"//extensions/strings",
"//mojo/bindings/js",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/public/cpp/bindings",
"//mojo/bindings/js",
"//mojo/system",
"//testing/gmock",
"//testing/gtest",
"//third_party/leveldatabase",
Expand Down
2 changes: 1 addition & 1 deletion extensions/test/DEPS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include_rules = [
"+content/public",
"+mojo/embedder",
"+mojo/edk/embedder",
]
2 changes: 1 addition & 1 deletion extensions/test/extensions_unittests_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "extensions/common/constants.h"
#include "extensions/common/extension_paths.h"
#include "extensions/test/test_extensions_client.h"
#include "mojo/embedder/test_embedder.h"
#include "mojo/edk/embedder/test_embedder.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gl/gl_surface.h"

Expand Down
6 changes: 3 additions & 3 deletions ipc/mojo/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ component("mojo") {
"//ipc",
"//mojo/environment:chromium",
"//mojo/public/cpp/bindings",
"//mojo/system",
"//mojo/edk/system",
]
}

Expand All @@ -42,8 +42,8 @@ test("ipc_mojo_unittests") {
"//ipc",
"//ipc:test_support",
"//ipc/mojo",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/system",
"//url",
]
}
Expand All @@ -61,8 +61,8 @@ test("ipc_mojo_perftests") {
"//ipc",
"//ipc:test_support",
"//ipc/mojo",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/system",
"//url",
]
}
4 changes: 2 additions & 2 deletions ipc/mojo/DEPS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include_rules = [
"+mojo/public",
"+mojo/embedder",
]
"+mojo/edk/embedder",
]
2 changes: 1 addition & 1 deletion ipc/mojo/ipc_channel_mojo.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "ipc/ipc_listener.h"
#include "ipc/mojo/ipc_channel_mojo_readers.h"
#include "ipc/mojo/ipc_mojo_bootstrap.h"
#include "mojo/embedder/embedder.h"
#include "mojo/edk/embedder/embedder.h"

#if defined(OS_POSIX) && !defined(OS_NACL)
#include "ipc/file_descriptor_set_posix.h"
Expand Down
2 changes: 1 addition & 1 deletion ipc/mojo/ipc_channel_mojo_readers.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "ipc/mojo/ipc_channel_mojo_readers.h"

#include "ipc/mojo/ipc_channel_mojo.h"
#include "mojo/embedder/embedder.h"
#include "mojo/edk/embedder/embedder.h"

#if defined(OS_POSIX) && !defined(OS_NACL)
#include "ipc/file_descriptor_set_posix.h"
Expand Down
2 changes: 1 addition & 1 deletion ipc/mojo/ipc_channel_mojo_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ TEST_F(IPCChannelMojoErrorTest, SendFailWithPendingMessages) {
CreateChannel(&listener);
ASSERT_TRUE(ConnectChannel());

// This matches a value in mojo/system/constants.h
// This matches a value in mojo/edk/system/constants.h
const int kMaxMessageNumBytes = 4 * 1024 * 1024;
std::string overly_large_data(kMaxMessageNumBytes, '*');
// This messages are queued as pending.
Expand Down
2 changes: 1 addition & 1 deletion ipc/mojo/ipc_mojo_bootstrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "base/process/process_handle.h"
#include "ipc/ipc_message_utils.h"
#include "ipc/ipc_platform_file.h"
#include "mojo/embedder/platform_channel_pair.h"
#include "mojo/edk/embedder/platform_channel_pair.h"

namespace IPC {

Expand Down
2 changes: 1 addition & 1 deletion ipc/mojo/ipc_mojo_bootstrap.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "base/process/process_handle.h"
#include "ipc/ipc_channel.h"
#include "ipc/ipc_listener.h"
#include "mojo/embedder/scoped_platform_handle.h"
#include "mojo/edk/embedder/scoped_platform_handle.h"

namespace IPC {

Expand Down
2 changes: 1 addition & 1 deletion ipc/mojo/ipc_mojo_perftest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include "ipc/ipc_perftest_support.h"
#include "ipc/mojo/ipc_channel_mojo.h"
#include "ipc/mojo/ipc_channel_mojo_host.h"
#include "mojo/embedder/test_embedder.h"
#include "mojo/edk/embedder/test_embedder.h"

namespace {

Expand Down
2 changes: 1 addition & 1 deletion ipc/mojo/run_all_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include "base/bind.h"
#include "base/test/launcher/unit_test_launcher.h"
#include "base/test/test_suite.h"
#include "mojo/embedder/test_embedder.h"
#include "mojo/edk/embedder/test_embedder.h"

#if defined(OS_ANDROID)
#include "base/android/jni_android.h"
Expand Down
2 changes: 1 addition & 1 deletion media/mojo/services/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ test("media_mojo_lib_unittests") {
"//media",
"//media/mojo/interfaces",
"//mojo/common/test:run_all_unittests",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/system",
"//testing/gtest",
":lib"
]
Expand Down
4 changes: 2 additions & 2 deletions mojo/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ group("tests") {
"//mojo/application_manager:mojo_application_manager_unittests",
"//mojo/apps/js/test:mojo_apps_js_unittests",
"//mojo/common:mojo_common_unittests",
"//mojo/edk/system:mojo_message_pipe_perftests",
"//mojo/edk/system:mojo_system_unittests",
"//mojo/public/c/system/tests:perftests",
"//mojo/public/cpp/application/tests:mojo_public_application_unittests",
"//mojo/public/cpp/bindings/tests:mojo_public_bindings_unittests",
Expand All @@ -50,8 +52,6 @@ group("tests") {
"//mojo/services/public/cpp/surfaces/tests:mojo_surfaces_lib_unittests",
"//mojo/shell:mojo_external_application_tests",
"//mojo/shell:mojo_shell_tests",
"//mojo/system:mojo_message_pipe_perftests",
"//mojo/system:mojo_system_unittests",
"//mojo/tools:message_generator",
]

Expand Down
2 changes: 1 addition & 1 deletion mojo/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ include_rules = [
"+base",
"+build",
"+mojo",
"-mojo/system",
"-mojo/edk/system",
"+testing",
]
2 changes: 1 addition & 1 deletion mojo/PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.

"""Presubmit script for mojo/embedder.
"""Presubmit script for mojo
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details about the presubmit API built into depot_tools.
Expand Down
4 changes: 2 additions & 2 deletions mojo/android/javatests/init_library.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
#include "mojo/android/javatests/mojo_test_case.h"
#include "mojo/android/javatests/validation_test_util.h"
#include "mojo/android/system/core_impl.h"
#include "mojo/embedder/embedder.h"
#include "mojo/embedder/simple_platform_support.h"
#include "mojo/edk/embedder/embedder.h"
#include "mojo/edk/embedder/simple_platform_support.h"

namespace {

Expand Down
2 changes: 1 addition & 1 deletion mojo/application_manager/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ component("application_manager") {
"//base/third_party/dynamic_annotations",
"//net",
"//url",
"//mojo/edk/system",
"//mojo/environment:chromium",
"//mojo/services/public/interfaces/content_handler:content_handler",
"//mojo/system",
]
}

Expand Down
2 changes: 1 addition & 1 deletion mojo/apps/js/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test("mojo_apps_js_unittests") {
"//mojo/apps/js",
"//mojo/common",
"//mojo/common/test:run_all_unittests",
"//mojo/common/test:test_support",
"//mojo/edk/test:test_support",
"//mojo/public/interfaces/bindings/tests:test_interfaces",
]

Expand Down
2 changes: 1 addition & 1 deletion mojo/apps/js/test/js_to_cpp_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
#include "mojo/apps/js/mojo_runner_delegate.h"
#include "mojo/apps/js/test/js_to_cpp.mojom.h"
#include "mojo/common/common_type_converters.h"
#include "mojo/common/test/test_utils.h"
#include "mojo/edk/test/test_utils.h"
#include "mojo/public/cpp/system/core.h"
#include "mojo/public/cpp/system/macros.h"
#include "testing/gtest/include/gtest/gtest.h"
Expand Down
3 changes: 1 addition & 2 deletions mojo/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ test("mojo_common_unittests") {
"//base",
"//base:message_loop_tests",
"//mojo/common/test:run_all_unittests",
"//mojo/common/test:test_support",
"//mojo/edk/test:test_support",
"//mojo/environment:chromium",
"//mojo/public/cpp/bindings",
"//mojo/public/cpp/test_support:test_utils",
Expand All @@ -49,6 +49,5 @@ test("mojo_common_unittests") {
"common_type_converters_unittest.cc",
"handle_watcher_unittest.cc",
"message_pump_mojo_unittest.cc",
"test/multiprocess_test_helper_unittest.cc",
]
}
Loading

0 comments on commit ee7ff19

Please sign in to comment.