From d8b50bece6058f921006bc734bd045fa55ff49be Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Wed, 15 Jun 2011 14:19:44 +0000 Subject: [PATCH] Simplify the author check. 2 lines removed! R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7144016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89182 0039d316-1c4b-4281-b951-d872f2087c98 --- PRESUBMIT.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 6fface8db19a58..b11ed8d40d31f7 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -111,9 +111,7 @@ def _CheckAuthorizedAuthor(input_api, output_api): valid_authors = [item.group(1).lower() for item in valid_authors if item] if input_api.verbose: print 'Valid authors are %s' % ', '.join(valid_authors) - if not any( - True for valid in valid_authors - if fnmatch.fnmatch(author.lower(), valid)): + if not any(fnmatch.fnmatch(author.lower(), valid) for valid in valid_authors): return [output_api.PresubmitPromptWarning( ('%s is not in AUTHORS file. If you are a new contributor, please visit' '\n'