Skip to content

Commit

Permalink
macOS: Use system Xcode on 10.14.
Browse files Browse the repository at this point in the history
A previous CL: https://chromium-review.googlesource.com/c/1333877 commented out
an assert to allow default fallback to the local toolchain, but failed to update
the subsequent conditional correctly.

Bug: 904400
Change-Id: I8d299e60645db4821dbb79c45b57ac1c01767d57
Reviewed-on: https://chromium-review.googlesource.com/c/1335949
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608359}
  • Loading branch information
erikchen authored and Commit Bot committed Nov 15, 2018
1 parent 5bf868a commit d2619f3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build_overrides/build.gni
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,5 @@ if (host_os == "mac" && use_system_xcode == "") {
# assert(_result != 2,
# "Do not allow building targets with the default" +
# "hermetic toolchain if the minimum OS version is not met.")
use_system_xcode = _result == 0
use_system_xcode = _result != 1
}

0 comments on commit d2619f3

Please sign in to comment.