From d24d7b8bf5be294630a9c87340da16f04e2d2b42 Mon Sep 17 00:00:00 2001 From: Eric Stevenson Date: Thu, 5 Jul 2018 16:03:46 +0000 Subject: [PATCH] Mention internal proguard in APK size sheriffing docs. Internal proguard does a much better job at reducing Java code size so some Java alerts may not be actionable. Change-Id: I07d209c0e797946e9eda52f50158d19516c70447 Reviewed-on: https://chromium-review.googlesource.com/1127141 Commit-Queue: Eric Stevenson Reviewed-by: Peter Wen Cr-Commit-Position: refs/heads/master@{#572808} --- docs/speed/apk_size_regressions.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/speed/apk_size_regressions.md b/docs/speed/apk_size_regressions.md index 43545305414267..af1f8c3562018f 100644 --- a/docs/speed/apk_size_regressions.md +++ b/docs/speed/apk_size_regressions.md @@ -158,6 +158,11 @@ to show a diff of ELF symbols. * Use [//tools/binary_size/diagnose_bloat.py](https://chromium.googlesource.com/chromium/src/+/master/tools/binary_size/README.md) to show a diff of Java symbols. * Ensure any new Java deps are as specific as possible. + * If the change doesn't look suspect, check to see if the regression still + exists when internal proguard is used (see + [downstream graphs](https://chromeperf.appspot.com/report?sid=83bf643964a326648325f7eb6767d8adb85d67db8306dd94aa7476ed70d7dace) + or use `diagnose_bloat.py -v --enable-chrome-android-internal REV` + to build locally) ### Growth is from "other lib size" or "Unknown files size"