Skip to content

Commit

Permalink
Mention internal proguard in APK size sheriffing docs.
Browse files Browse the repository at this point in the history
Internal proguard does a much better job at reducing Java code size so
some Java alerts may not be actionable.

Change-Id: I07d209c0e797946e9eda52f50158d19516c70447
Reviewed-on: https://chromium-review.googlesource.com/1127141
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572808}
  • Loading branch information
Eric Stevenson authored and Commit Bot committed Jul 5, 2018
1 parent 70d2c8f commit d24d7b8
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions docs/speed/apk_size_regressions.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,11 @@ to show a diff of ELF symbols.
* Use [//tools/binary_size/diagnose_bloat.py](https://chromium.googlesource.com/chromium/src/+/master/tools/binary_size/README.md)
to show a diff of Java symbols.
* Ensure any new Java deps are as specific as possible.
* If the change doesn't look suspect, check to see if the regression still
exists when internal proguard is used (see
[downstream graphs](https://chromeperf.appspot.com/report?sid=83bf643964a326648325f7eb6767d8adb85d67db8306dd94aa7476ed70d7dace)
or use `diagnose_bloat.py -v --enable-chrome-android-internal REV`
to build locally)

### Growth is from "other lib size" or "Unknown files size"

Expand Down

0 comments on commit d24d7b8

Please sign in to comment.