Skip to content

Commit

Permalink
Revert 212948 "Made MessagePump a non-thread safe class."
Browse files Browse the repository at this point in the history
r212948 broke Mac Builder: http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Builder/builds/25623

> Made MessagePump a non-thread safe class.
> 
> This CL makes MessagePump a non-thread safe class to make sure thread-bound resources (such as the UI window used for pumping messages on Windows) are freed on the correct thread.
> 
> Handling of incoming tasks and synchronization between different threads was moved out to a separate class - IncomingTaskQueue reducing the number of locks to be taken while posting a task to one. Posting tasks via both MessageLoop and MessageLoopProxyImpl is now routed via IncomingTaskQueue.
> 
> BUG=241939
> 
> Review URL: https://chromiumcodereview.appspot.com/17567007

TBR=alexeypa@chromium.org

Review URL: https://codereview.chromium.org/19737005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212952 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
alexeypa@google.com committed Jul 22, 2013
1 parent 7552e6b commit c9904b4
Show file tree
Hide file tree
Showing 34 changed files with 405 additions and 490 deletions.
2 changes: 0 additions & 2 deletions base/base.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,6 @@
'memory/singleton.h',
'memory/weak_ptr.cc',
'memory/weak_ptr.h',
'message_loop/incoming_task_queue.cc',
'message_loop/incoming_task_queue.h',
'message_loop/message_loop.cc',
'message_loop/message_loop.h',
'message_loop/message_loop_proxy.cc',
Expand Down
169 changes: 0 additions & 169 deletions base/message_loop/incoming_task_queue.cc

This file was deleted.

104 changes: 0 additions & 104 deletions base/message_loop/incoming_task_queue.h

This file was deleted.

Loading

0 comments on commit c9904b4

Please sign in to comment.