From bc46d9b9849a916912512a2acfc9db3795cedec5 Mon Sep 17 00:00:00 2001 From: River Gilhuly Date: Mon, 12 Apr 2021 17:02:17 +0000 Subject: [PATCH] Transfer TODOs to rivr@ Update my TODO comments following a username change. Change-Id: If36565c6d47a4776537a666396a310e4b504131f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2819039 Reviewed-by: Zhenyao Mo Reviewed-by: kylechar Reviewed-by: Stephen White Commit-Queue: River Gilhuly Cr-Commit-Position: refs/heads/master@{#871515} --- cc/mojo_embedder/async_layer_tree_frame_sink.cc | 2 +- cc/test/layer_tree_test.cc | 2 +- cc/test/pixel_test.cc | 2 +- cc/trees/layer_tree_host_pixeltest_tiles.cc | 2 +- components/ui_devtools/viz/dom_agent_viz.cc | 4 ++-- components/ui_devtools/viz/viz_devtools_unittest.cc | 2 +- components/viz/common/BUILD.gn | 2 +- components/viz/common/gpu/dawn_context_provider.cc | 2 +- .../viz/service/display_embedder/skia_output_device_dawn.cc | 4 ++-- .../display_embedder/skia_output_surface_impl_on_gpu.cc | 2 +- components/viz/test/fake_skia_output_surface.cc | 2 +- components/viz/test/test_gpu_service_holder.cc | 2 +- content/browser/compositor/viz_process_transport_factory.cc | 2 +- content/browser/gpu/compositor_util.cc | 2 +- content/browser/gpu/gpu_data_manager_impl_private.cc | 2 +- content/browser/gpu/gpu_process_host.cc | 2 +- content/test/gpu/gpu_tests/gpu_helper.py | 2 +- skia/features.gni | 2 +- .../filters/gpu.linux.skiarenderer_dawn_viz_unittests.filter | 2 +- ui/compositor/test/in_process_context_factory.cc | 2 +- 20 files changed, 22 insertions(+), 22 deletions(-) diff --git a/cc/mojo_embedder/async_layer_tree_frame_sink.cc b/cc/mojo_embedder/async_layer_tree_frame_sink.cc index ad8fa37b9fed34..1f66b6e6a05c25 100644 --- a/cc/mojo_embedder/async_layer_tree_frame_sink.cc +++ b/cc/mojo_embedder/async_layer_tree_frame_sink.cc @@ -303,7 +303,7 @@ void AsyncLayerTreeFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) { void AsyncLayerTreeFrameSink::OnMojoConnectionError( uint32_t custom_reason, const std::string& description) { - // TODO(sgilhuly): Use DLOG(FATAL) once crbug.com/1043899 is resolved. + // TODO(rivr): Use DLOG(FATAL) once crbug.com/1043899 is resolved. if (custom_reason) DLOG(ERROR) << description; if (client_) diff --git a/cc/test/layer_tree_test.cc b/cc/test/layer_tree_test.cc index 3eea6c516518fa..52d1afc444738e 100644 --- a/cc/test/layer_tree_test.cc +++ b/cc/test/layer_tree_test.cc @@ -677,7 +677,7 @@ LayerTreeTest::LayerTreeTest(viz::RendererType renderer_type) #if defined(OS_LINUX) || defined(OS_CHROMEOS) init_vulkan = true; #elif defined(OS_WIN) - // TODO(sgilhuly): Initialize D3D12 for Windows. + // TODO(rivr): Initialize D3D12 for Windows. #else NOTREACHED(); #endif diff --git a/cc/test/pixel_test.cc b/cc/test/pixel_test.cc index 1fa414eccd80c4..78edac9d8a2fd9 100644 --- a/cc/test/pixel_test.cc +++ b/cc/test/pixel_test.cc @@ -74,7 +74,7 @@ PixelTest::PixelTest(GraphicsBackend backend) #if defined(OS_LINUX) || defined(OS_CHROMEOS) init_vulkan = true; #elif defined(OS_WIN) - // TODO(sgilhuly): Initialize D3D12 for Windows. + // TODO(rivr): Initialize D3D12 for Windows. #else NOTREACHED(); #endif diff --git a/cc/trees/layer_tree_host_pixeltest_tiles.cc b/cc/trees/layer_tree_host_pixeltest_tiles.cc index a10ad840469cb1..c82cf696f1c17f 100644 --- a/cc/trees/layer_tree_host_pixeltest_tiles.cc +++ b/cc/trees/layer_tree_host_pixeltest_tiles.cc @@ -267,7 +267,7 @@ std::vector const kTestCasesMultiThread = { {viz::RendererType::kSkiaGL, TestRasterType::kOneCopy}, #endif // BUILDFLAG(ENABLE_GL_BACKEND_TESTS) #if BUILDFLAG(ENABLE_VULKAN_BACKEND_TESTS) - // TODO(sgilhuly): Switch this to one copy raster once is is supported for + // TODO(rivr): Switch this to one copy raster once is is supported for // Vulkan in these tests. {viz::RendererType::kSkiaVk, TestRasterType::kOop}, #endif // BUILDFLAG(ENABLE_VULKAN_BACKEND_TESTS) diff --git a/components/ui_devtools/viz/dom_agent_viz.cc b/components/ui_devtools/viz/dom_agent_viz.cc index 543b9ceebb37a4..35631be8d9035b 100644 --- a/components/ui_devtools/viz/dom_agent_viz.cc +++ b/components/ui_devtools/viz/dom_agent_viz.cc @@ -107,7 +107,7 @@ void DOMAgentViz::OnSurfaceDestroyed(const viz::SurfaceId& surface_id) { DestroyElementAndRemoveSubtree(it->second.get()); } -// TODO(sgilhuly): Add support for elements to have multiple parents. Currently, +// TODO(rivr): Add support for elements to have multiple parents. Currently, // when a reference is added to a surface, the SurfaceElement is moved to be a // child of only its most recent referrer. When a reference is removed from a // surface, this is ignored unless the reference is to the SurfaceElement's @@ -151,7 +151,7 @@ void DOMAgentViz::OnRemovedSurfaceReference(const viz::SurfaceId& parent_id, // happen when we have Surface A referencing Surface B, then we create // Surface C and ask it to reference Surface B. When A asks to remove // the reference to B, do nothing because B is already referenced by C. - // TODO(sgilhuly): Add support for elements to have multiple parents so this + // TODO(rivr): Add support for elements to have multiple parents so this // case can be correctly handled. UIElement* old_parent = child->parent(); if (SurfaceElement::From(old_parent) != parent_id) diff --git a/components/ui_devtools/viz/viz_devtools_unittest.cc b/components/ui_devtools/viz/viz_devtools_unittest.cc index ce8472c6414532..69d07917270f99 100644 --- a/components/ui_devtools/viz/viz_devtools_unittest.cc +++ b/components/ui_devtools/viz/viz_devtools_unittest.cc @@ -417,7 +417,7 @@ TEST_F(VizDevToolsTest, SurfaceHierarchyCleanup) { // Verify that a surface with multiple references is only a child of its most // recent referrer. -// TODO(sgilhuly): This test follows the current behaviour of surfaces with +// TODO(rivr): This test follows the current behaviour of surfaces with // multiple references, and should be changed if support for nodes to have // multiple parents is added. TEST_F(VizDevToolsTest, MultipleSurfaceReferences) { diff --git a/components/viz/common/BUILD.gn b/components/viz/common/BUILD.gn index ae09dd6919af6e..a424619cf9100c 100644 --- a/components/viz/common/BUILD.gn +++ b/components/viz/common/BUILD.gn @@ -44,7 +44,7 @@ viz_component("resource_format_utils") { } } -# TODO(sgilhuly): To reduce link times, merge these context provider components +# TODO(rivr): To reduce link times, merge these context provider components # into a single gr_context_provider component. if (is_mac) { viz_component("metal_context_provider") { diff --git a/components/viz/common/gpu/dawn_context_provider.cc b/components/viz/common/gpu/dawn_context_provider.cc index 2e54f9165856c8..d4004c125e9b0b 100644 --- a/components/viz/common/gpu/dawn_context_provider.cc +++ b/components/viz/common/gpu/dawn_context_provider.cc @@ -38,7 +38,7 @@ std::unique_ptr DawnContextProvider::Create() { } DawnContextProvider::DawnContextProvider() { - // TODO(sgilhuly): This may return a GPU that is not the active one. Currently + // TODO(rivr): This may return a GPU that is not the active one. Currently // the only known way to avoid this is platform-specific; e.g. on Mac, create // a Dawn device, get the actual Metal device from it, and compare against // MTLCreateSystemDefaultDevice(). diff --git a/components/viz/service/display_embedder/skia_output_device_dawn.cc b/components/viz/service/display_embedder/skia_output_device_dawn.cc index 0b258857b89dcc..6673cfedd01117 100644 --- a/components/viz/service/display_embedder/skia_output_device_dawn.cc +++ b/components/viz/service/display_embedder/skia_output_device_dawn.cc @@ -77,7 +77,7 @@ bool SkiaOutputDeviceDawn::Reshape(const gfx::Size& size, CreateSwapChainImplementation(); wgpu::SwapChainDescriptor desc; desc.implementation = reinterpret_cast(&swap_chain_implementation_); - // TODO(sgilhuly): Use a wgpu::Surface in this call once the Surface-based + // TODO(rivr): Use a wgpu::Surface in this call once the Surface-based // SwapChain API is ready. swap_chain_ = context_provider_->GetDevice().CreateSwapChain(nullptr, &desc); if (!swap_chain_) @@ -98,7 +98,7 @@ void SkiaOutputDeviceDawn::SwapBuffers(BufferPresentedCallback feedback, base::TimeTicks vsync_timebase; base::TimeDelta vsync_interval; uint32_t flags = 0; - // TODO(sgilhuly): Add an async path for getting vsync parameters. The sync + // TODO(rivr): Add an async path for getting vsync parameters. The sync // path is sufficient for VSyncProviderWin. if (vsync_provider_ && vsync_provider_->GetVSyncParametersIfAvailable( &vsync_timebase, &vsync_interval)) { diff --git a/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc b/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc index 199491add767ab..3c75af5f3c96d0 100644 --- a/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc +++ b/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc @@ -1488,7 +1488,7 @@ bool SkiaOutputSurfaceImplOnGpu::InitializeForDawn() { GetDidSwapBuffersCompleteCallback()); } else { #if defined(USE_X11) || defined(USE_OZONE_PLATFORM_X11) - // TODO(sgilhuly): Set up a Vulkan swapchain so that Linux can also use + // TODO(rivr): Set up a Vulkan swapchain so that Linux can also use // SkiaOutputDeviceDawn. if (MayFallBackToSkiaOutputDeviceX11()) { output_device_ = SkiaOutputDeviceX11::Create( diff --git a/components/viz/test/fake_skia_output_surface.cc b/components/viz/test/fake_skia_output_surface.cc index e6ae003161261d..198205510bca47 100644 --- a/components/viz/test/fake_skia_output_surface.cc +++ b/components/viz/test/fake_skia_output_surface.cc @@ -265,7 +265,7 @@ void FakeSkiaOutputSurface::CopyOutput( } if (request->result_format() == CopyOutputResult::Format::RGBA_TEXTURE) { - // TODO(sgilhuly): This implementation is incomplete and doesn't copy + // TODO(rivr): This implementation is incomplete and doesn't copy // anything into the mailbox, but currently the only tests that use this // don't actually check the returned texture data. auto* sii = context_provider_->SharedImageInterface(); diff --git a/components/viz/test/test_gpu_service_holder.cc b/components/viz/test/test_gpu_service_holder.cc index 7f03e442eb1274..9bf8044e5b2528 100644 --- a/components/viz/test/test_gpu_service_holder.cc +++ b/components/viz/test/test_gpu_service_holder.cc @@ -220,7 +220,7 @@ void TestGpuServiceHolder::InitializeOnGpuThread( gpu_feature_info.status_values[gpu::GPU_FEATURE_TYPE_OOP_RASTERIZATION] = gpu::kGpuFeatureStatusEnabled; - // TODO(sgilhuly): Investigate why creating a GPUInfo and GpuFeatureInfo from + // TODO(rivr): Investigate why creating a GPUInfo and GpuFeatureInfo from // the command line causes the test SkiaOutputSurfaceImplTest.SubmitPaint to // fail on Android. gpu_service_ = std::make_unique( diff --git a/content/browser/compositor/viz_process_transport_factory.cc b/content/browser/compositor/viz_process_transport_factory.cc index 2d80f84280b5a6..b1d4cf3b353a59 100644 --- a/content/browser/compositor/viz_process_transport_factory.cc +++ b/content/browser/compositor/viz_process_transport_factory.cc @@ -495,7 +495,7 @@ VizProcessTransportFactory::TryCreateContextsForGpuCompositing( const auto& gpu_feature_info = gpu_channel_host->gpu_feature_info(); // Fallback to software compositing if GPU compositing is blacklisted. - // TODO(sgilhuly): For now assume that if GL is blacklisted, then Vulkan is + // TODO(rivr): For now assume that if GL is blacklisted, then Vulkan is // also. Just check GL to see if GPU compositing is disabled. auto gpu_compositing_status = gpu_feature_info.status_values[gpu::GPU_FEATURE_TYPE_ACCELERATED_GL]; diff --git a/content/browser/gpu/compositor_util.cc b/content/browser/gpu/compositor_util.cc index cc59a49e173b2f..2f29c71b1826d5 100644 --- a/content/browser/gpu/compositor_util.cc +++ b/content/browser/gpu/compositor_util.cc @@ -105,7 +105,7 @@ const GpuFeatureData GetGpuFeatureData( "via blocklist or the command line."), true}, {"gpu_compositing", - // TODO(sgilhuly): Replace with a check to see which backend is used for + // TODO(rivr): Replace with a check to see which backend is used for // compositing; do the same for GPU rasterization if it's enabled. For now // assume that if GL is blocklisted, then Vulkan is also. Check GL to see // if GPU compositing is disabled. diff --git a/content/browser/gpu/gpu_data_manager_impl_private.cc b/content/browser/gpu/gpu_data_manager_impl_private.cc index 4c67be38f54198..d4a667b732df33 100644 --- a/content/browser/gpu/gpu_data_manager_impl_private.cc +++ b/content/browser/gpu/gpu_data_manager_impl_private.cc @@ -1110,7 +1110,7 @@ void GpuDataManagerImplPrivate::UpdateGpuFeatureInfo( if (gpu_mode_ == gpu::GpuMode::HARDWARE_VULKAN && gpu_feature_info_.status_values[gpu::GPU_FEATURE_TYPE_VULKAN] != gpu::GpuFeatureStatus::kGpuFeatureStatusEnabled) { - // TODO(sgilhuly): The GpuMode in GpuProcessHost will still be + // TODO(rivr): The GpuMode in GpuProcessHost will still be // HARDWARE_VULKAN. This isn't a big issue right now because both GPU modes // report to the same histogram. The first fallback will occur after 4 // crashes, instead of 3. diff --git a/content/browser/gpu/gpu_process_host.cc b/content/browser/gpu/gpu_process_host.cc index 9b18e1b5c476f1..b826594d031b3a 100644 --- a/content/browser/gpu/gpu_process_host.cc +++ b/content/browser/gpu/gpu_process_host.cc @@ -137,7 +137,7 @@ constexpr char kProcessLifetimeEventsDisplayCompositor[] = // Returns the UMA histogram name for the given GPU mode. const char* GetProcessLifetimeUmaName(gpu::GpuMode gpu_mode) { switch (gpu_mode) { - // TODO(sgilhuly): Add separate histograms for the different hardware modes. + // TODO(rivr): Add separate histograms for the different hardware modes. case gpu::GpuMode::HARDWARE_GL: case gpu::GpuMode::HARDWARE_METAL: case gpu::GpuMode::HARDWARE_VULKAN: diff --git a/content/test/gpu/gpu_tests/gpu_helper.py b/content/test/gpu/gpu_tests/gpu_helper.py index 06b10eb0619ab0..dd8a62be7376b5 100644 --- a/content/test/gpu/gpu_tests/gpu_helper.py +++ b/content/test/gpu/gpu_tests/gpu_helper.py @@ -168,7 +168,7 @@ def GetDisplayServer(): return None -# TODO(sgilhuly): Use GPU feature status for Dawn instead of command line. +# TODO(rivr): Use GPU feature status for Dawn instead of command line. def HasDawnSkiaRenderer(extra_browser_args): if extra_browser_args: for arg in extra_browser_args: diff --git a/skia/features.gni b/skia/features.gni index 894e8f616ce516..5675938b6ed2e1 100644 --- a/skia/features.gni +++ b/skia/features.gni @@ -8,7 +8,7 @@ declare_args() { skia_use_gl = true # Enable gtests using SkiaRenderer Dawn. - # TODO(sgilhuly): Remove this and enable the tests by default once a software + # TODO(rivr): Remove this and enable the tests by default once a software # path for D3D12 is available. enable_skia_dawn_gtests = false } diff --git a/testing/buildbot/filters/gpu.linux.skiarenderer_dawn_viz_unittests.filter b/testing/buildbot/filters/gpu.linux.skiarenderer_dawn_viz_unittests.filter index 8a933506c4a031..1743a29a95a796 100644 --- a/testing/buildbot/filters/gpu.linux.skiarenderer_dawn_viz_unittests.filter +++ b/testing/buildbot/filters/gpu.linux.skiarenderer_dawn_viz_unittests.filter @@ -1 +1 @@ -# TODO(sgilhuly): Remove this file once SkiaRenderer Dawn is more stable. +# TODO(rivr): Remove this file once SkiaRenderer Dawn is more stable. diff --git a/ui/compositor/test/in_process_context_factory.cc b/ui/compositor/test/in_process_context_factory.cc index 4eceaeed2a1fdc..d4e5b2ab792c6e 100644 --- a/ui/compositor/test/in_process_context_factory.cc +++ b/ui/compositor/test/in_process_context_factory.cc @@ -145,7 +145,7 @@ class DirectOutputSurface : public viz::OutputSurface { } // namespace -// TODO(sgilhuly): This class is managed heavily by InProcessTransportFactory. +// TODO(rivr): This class is managed heavily by InProcessTransportFactory. // Move some of the logic in here and simplify the interface. class InProcessContextFactory::PerCompositorData : public viz::mojom::DisplayPrivate {