Skip to content

Commit

Permalink
Transfer TODOs to rivr@
Browse files Browse the repository at this point in the history
Update my TODO comments following a username change.

Change-Id: If36565c6d47a4776537a666396a310e4b504131f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2819039
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: River Gilhuly <rivr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#871515}
  • Loading branch information
River Gilhuly authored and Chromium LUCI CQ committed Apr 12, 2021
1 parent 9c8d47f commit bc46d9b
Show file tree
Hide file tree
Showing 20 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion cc/mojo_embedder/async_layer_tree_frame_sink.cc
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ void AsyncLayerTreeFrameSink::OnNeedsBeginFrames(bool needs_begin_frames) {
void AsyncLayerTreeFrameSink::OnMojoConnectionError(
uint32_t custom_reason,
const std::string& description) {
// TODO(sgilhuly): Use DLOG(FATAL) once crbug.com/1043899 is resolved.
// TODO(rivr): Use DLOG(FATAL) once crbug.com/1043899 is resolved.
if (custom_reason)
DLOG(ERROR) << description;
if (client_)
Expand Down
2 changes: 1 addition & 1 deletion cc/test/layer_tree_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ LayerTreeTest::LayerTreeTest(viz::RendererType renderer_type)
#if defined(OS_LINUX) || defined(OS_CHROMEOS)
init_vulkan = true;
#elif defined(OS_WIN)
// TODO(sgilhuly): Initialize D3D12 for Windows.
// TODO(rivr): Initialize D3D12 for Windows.
#else
NOTREACHED();
#endif
Expand Down
2 changes: 1 addition & 1 deletion cc/test/pixel_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ PixelTest::PixelTest(GraphicsBackend backend)
#if defined(OS_LINUX) || defined(OS_CHROMEOS)
init_vulkan = true;
#elif defined(OS_WIN)
// TODO(sgilhuly): Initialize D3D12 for Windows.
// TODO(rivr): Initialize D3D12 for Windows.
#else
NOTREACHED();
#endif
Expand Down
2 changes: 1 addition & 1 deletion cc/trees/layer_tree_host_pixeltest_tiles.cc
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ std::vector<RasterTestConfig> const kTestCasesMultiThread = {
{viz::RendererType::kSkiaGL, TestRasterType::kOneCopy},
#endif // BUILDFLAG(ENABLE_GL_BACKEND_TESTS)
#if BUILDFLAG(ENABLE_VULKAN_BACKEND_TESTS)
// TODO(sgilhuly): Switch this to one copy raster once is is supported for
// TODO(rivr): Switch this to one copy raster once is is supported for
// Vulkan in these tests.
{viz::RendererType::kSkiaVk, TestRasterType::kOop},
#endif // BUILDFLAG(ENABLE_VULKAN_BACKEND_TESTS)
Expand Down
4 changes: 2 additions & 2 deletions components/ui_devtools/viz/dom_agent_viz.cc
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ void DOMAgentViz::OnSurfaceDestroyed(const viz::SurfaceId& surface_id) {
DestroyElementAndRemoveSubtree(it->second.get());
}

// TODO(sgilhuly): Add support for elements to have multiple parents. Currently,
// TODO(rivr): Add support for elements to have multiple parents. Currently,
// when a reference is added to a surface, the SurfaceElement is moved to be a
// child of only its most recent referrer. When a reference is removed from a
// surface, this is ignored unless the reference is to the SurfaceElement's
Expand Down Expand Up @@ -151,7 +151,7 @@ void DOMAgentViz::OnRemovedSurfaceReference(const viz::SurfaceId& parent_id,
// happen when we have Surface A referencing Surface B, then we create
// Surface C and ask it to reference Surface B. When A asks to remove
// the reference to B, do nothing because B is already referenced by C.
// TODO(sgilhuly): Add support for elements to have multiple parents so this
// TODO(rivr): Add support for elements to have multiple parents so this
// case can be correctly handled.
UIElement* old_parent = child->parent();
if (SurfaceElement::From(old_parent) != parent_id)
Expand Down
2 changes: 1 addition & 1 deletion components/ui_devtools/viz/viz_devtools_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ TEST_F(VizDevToolsTest, SurfaceHierarchyCleanup) {

// Verify that a surface with multiple references is only a child of its most
// recent referrer.
// TODO(sgilhuly): This test follows the current behaviour of surfaces with
// TODO(rivr): This test follows the current behaviour of surfaces with
// multiple references, and should be changed if support for nodes to have
// multiple parents is added.
TEST_F(VizDevToolsTest, MultipleSurfaceReferences) {
Expand Down
2 changes: 1 addition & 1 deletion components/viz/common/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ viz_component("resource_format_utils") {
}
}

# TODO(sgilhuly): To reduce link times, merge these context provider components
# TODO(rivr): To reduce link times, merge these context provider components
# into a single gr_context_provider component.
if (is_mac) {
viz_component("metal_context_provider") {
Expand Down
2 changes: 1 addition & 1 deletion components/viz/common/gpu/dawn_context_provider.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ std::unique_ptr<DawnContextProvider> DawnContextProvider::Create() {
}

DawnContextProvider::DawnContextProvider() {
// TODO(sgilhuly): This may return a GPU that is not the active one. Currently
// TODO(rivr): This may return a GPU that is not the active one. Currently
// the only known way to avoid this is platform-specific; e.g. on Mac, create
// a Dawn device, get the actual Metal device from it, and compare against
// MTLCreateSystemDefaultDevice().
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ bool SkiaOutputDeviceDawn::Reshape(const gfx::Size& size,
CreateSwapChainImplementation();
wgpu::SwapChainDescriptor desc;
desc.implementation = reinterpret_cast<int64_t>(&swap_chain_implementation_);
// TODO(sgilhuly): Use a wgpu::Surface in this call once the Surface-based
// TODO(rivr): Use a wgpu::Surface in this call once the Surface-based
// SwapChain API is ready.
swap_chain_ = context_provider_->GetDevice().CreateSwapChain(nullptr, &desc);
if (!swap_chain_)
Expand All @@ -98,7 +98,7 @@ void SkiaOutputDeviceDawn::SwapBuffers(BufferPresentedCallback feedback,
base::TimeTicks vsync_timebase;
base::TimeDelta vsync_interval;
uint32_t flags = 0;
// TODO(sgilhuly): Add an async path for getting vsync parameters. The sync
// TODO(rivr): Add an async path for getting vsync parameters. The sync
// path is sufficient for VSyncProviderWin.
if (vsync_provider_ && vsync_provider_->GetVSyncParametersIfAvailable(
&vsync_timebase, &vsync_interval)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1488,7 +1488,7 @@ bool SkiaOutputSurfaceImplOnGpu::InitializeForDawn() {
GetDidSwapBuffersCompleteCallback());
} else {
#if defined(USE_X11) || defined(USE_OZONE_PLATFORM_X11)
// TODO(sgilhuly): Set up a Vulkan swapchain so that Linux can also use
// TODO(rivr): Set up a Vulkan swapchain so that Linux can also use
// SkiaOutputDeviceDawn.
if (MayFallBackToSkiaOutputDeviceX11()) {
output_device_ = SkiaOutputDeviceX11::Create(
Expand Down
2 changes: 1 addition & 1 deletion components/viz/test/fake_skia_output_surface.cc
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ void FakeSkiaOutputSurface::CopyOutput(
}

if (request->result_format() == CopyOutputResult::Format::RGBA_TEXTURE) {
// TODO(sgilhuly): This implementation is incomplete and doesn't copy
// TODO(rivr): This implementation is incomplete and doesn't copy
// anything into the mailbox, but currently the only tests that use this
// don't actually check the returned texture data.
auto* sii = context_provider_->SharedImageInterface();
Expand Down
2 changes: 1 addition & 1 deletion components/viz/test/test_gpu_service_holder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ void TestGpuServiceHolder::InitializeOnGpuThread(
gpu_feature_info.status_values[gpu::GPU_FEATURE_TYPE_OOP_RASTERIZATION] =
gpu::kGpuFeatureStatusEnabled;

// TODO(sgilhuly): Investigate why creating a GPUInfo and GpuFeatureInfo from
// TODO(rivr): Investigate why creating a GPUInfo and GpuFeatureInfo from
// the command line causes the test SkiaOutputSurfaceImplTest.SubmitPaint to
// fail on Android.
gpu_service_ = std::make_unique<GpuServiceImpl>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ VizProcessTransportFactory::TryCreateContextsForGpuCompositing(

const auto& gpu_feature_info = gpu_channel_host->gpu_feature_info();
// Fallback to software compositing if GPU compositing is blacklisted.
// TODO(sgilhuly): For now assume that if GL is blacklisted, then Vulkan is
// TODO(rivr): For now assume that if GL is blacklisted, then Vulkan is
// also. Just check GL to see if GPU compositing is disabled.
auto gpu_compositing_status =
gpu_feature_info.status_values[gpu::GPU_FEATURE_TYPE_ACCELERATED_GL];
Expand Down
2 changes: 1 addition & 1 deletion content/browser/gpu/compositor_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ const GpuFeatureData GetGpuFeatureData(
"via blocklist or the command line."),
true},
{"gpu_compositing",
// TODO(sgilhuly): Replace with a check to see which backend is used for
// TODO(rivr): Replace with a check to see which backend is used for
// compositing; do the same for GPU rasterization if it's enabled. For now
// assume that if GL is blocklisted, then Vulkan is also. Check GL to see
// if GPU compositing is disabled.
Expand Down
2 changes: 1 addition & 1 deletion content/browser/gpu/gpu_data_manager_impl_private.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,7 @@ void GpuDataManagerImplPrivate::UpdateGpuFeatureInfo(
if (gpu_mode_ == gpu::GpuMode::HARDWARE_VULKAN &&
gpu_feature_info_.status_values[gpu::GPU_FEATURE_TYPE_VULKAN] !=
gpu::GpuFeatureStatus::kGpuFeatureStatusEnabled) {
// TODO(sgilhuly): The GpuMode in GpuProcessHost will still be
// TODO(rivr): The GpuMode in GpuProcessHost will still be
// HARDWARE_VULKAN. This isn't a big issue right now because both GPU modes
// report to the same histogram. The first fallback will occur after 4
// crashes, instead of 3.
Expand Down
2 changes: 1 addition & 1 deletion content/browser/gpu/gpu_process_host.cc
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ constexpr char kProcessLifetimeEventsDisplayCompositor[] =
// Returns the UMA histogram name for the given GPU mode.
const char* GetProcessLifetimeUmaName(gpu::GpuMode gpu_mode) {
switch (gpu_mode) {
// TODO(sgilhuly): Add separate histograms for the different hardware modes.
// TODO(rivr): Add separate histograms for the different hardware modes.
case gpu::GpuMode::HARDWARE_GL:
case gpu::GpuMode::HARDWARE_METAL:
case gpu::GpuMode::HARDWARE_VULKAN:
Expand Down
2 changes: 1 addition & 1 deletion content/test/gpu/gpu_tests/gpu_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def GetDisplayServer():
return None


# TODO(sgilhuly): Use GPU feature status for Dawn instead of command line.
# TODO(rivr): Use GPU feature status for Dawn instead of command line.
def HasDawnSkiaRenderer(extra_browser_args):
if extra_browser_args:
for arg in extra_browser_args:
Expand Down
2 changes: 1 addition & 1 deletion skia/features.gni
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ declare_args() {
skia_use_gl = true

# Enable gtests using SkiaRenderer Dawn.
# TODO(sgilhuly): Remove this and enable the tests by default once a software
# TODO(rivr): Remove this and enable the tests by default once a software
# path for D3D12 is available.
enable_skia_dawn_gtests = false
}
Original file line number Diff line number Diff line change
@@ -1 +1 @@
# TODO(sgilhuly): Remove this file once SkiaRenderer Dawn is more stable.
# TODO(rivr): Remove this file once SkiaRenderer Dawn is more stable.
2 changes: 1 addition & 1 deletion ui/compositor/test/in_process_context_factory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ class DirectOutputSurface : public viz::OutputSurface {

} // namespace

// TODO(sgilhuly): This class is managed heavily by InProcessTransportFactory.
// TODO(rivr): This class is managed heavily by InProcessTransportFactory.
// Move some of the logic in here and simplify the interface.
class InProcessContextFactory::PerCompositorData
: public viz::mojom::DisplayPrivate {
Expand Down

0 comments on commit bc46d9b

Please sign in to comment.