From b4c9b9e921fbc4d89b8e9b905d237fb10ac45add Mon Sep 17 00:00:00 2001 From: Daniel Erat Date: Tue, 4 Jun 2019 23:57:26 +0000 Subject: [PATCH] Delete derat@chromium.org from OWNERS files. Delete myself from various OWNERS files. Also delete my entries from WATCHLISTS and delete an old TODO. Bug: none Change-Id: Id226c2eb8ecf2aebe1c9dd2008f52de5f2050a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643400 Commit-Queue: Dan Erat Auto-Submit: Dan Erat Reviewed-by: Scott Violet Cr-Commit-Position: refs/heads/master@{#666057} --- WATCHLISTS | 18 ++---------------- ash/OWNERS | 1 - base/i18n/time_formatting.h | 4 ---- chrome/browser/chromeos/OWNERS | 1 - .../extensions/autotest_private/OWNERS | 1 - chrome/browser/chromeos/power/ml/OWNERS | 1 - chrome/browser/ui/ash/OWNERS | 1 - chromeos/OWNERS | 1 - chromeos/dbus/OWNERS | 1 - chromeos/dbus/power/OWNERS | 1 - components/timers/OWNERS | 1 - extensions/browser/OWNERS | 1 - extensions/browser/api/power/OWNERS | 1 - .../device/wake_lock/power_save_blocker/OWNERS | 1 - ui/base/cursor/OWNERS | 1 - ui/base/x/OWNERS | 4 ++-- ui/chromeos/OWNERS | 1 - ui/display/OWNERS | 1 - ui/gfx/OWNERS | 3 --- ui/gfx/test/OWNERS | 2 -- ui/gfx/x/OWNERS | 2 +- ui/wm/core/OWNERS | 1 - 22 files changed, 5 insertions(+), 44 deletions(-) delete mode 100644 chromeos/dbus/power/OWNERS delete mode 100644 extensions/browser/api/power/OWNERS delete mode 100644 ui/base/cursor/OWNERS delete mode 100644 ui/gfx/test/OWNERS diff --git a/WATCHLISTS b/WATCHLISTS index afa120f596ff2b..dd6750391881af 100644 --- a/WATCHLISTS +++ b/WATCHLISTS @@ -767,11 +767,6 @@ 'extensions/browser/api/networking_private/|'\ 'ui/chromeos/network/', }, - 'chromeos_power': { - 'filepath': 'ash/system/power/|'\ - 'chromeos/dbus/power_.*|'\ - 'chrome/browser/chromeos/power/', - }, 'chromeos_timezone': { 'filepath': 'chromeos/timezone/', }, @@ -1111,11 +1106,6 @@ 'filepath': 'third_party/libxml/' \ '|third_party/libxslt/', }, - 'linux_fonts': { - 'filepath': 'ui/gfx/font_render_params_.*|'\ - 'ui/gfx/platform_font_linux.*|'\ - 'ui/gfx/render_text_harfbuzz.*', - }, 'linux_sandboxing': { 'filepath': 'sandbox/linux/', }, @@ -1886,8 +1876,7 @@ 'WATCHLISTS': { 'about_flags': ['asvitkine+watch@chromium.org', 'jmedley+watch@chromium.org'], - 'accelerator_table': ['derat+watch@chromium.org', - 'yusukes+watch@chromium.org'], + 'accelerator_table': ['yusukes+watch@chromium.org'], 'accessibility': ['aboxhall+watch@chromium.org', 'akihiroota@chromium.org', 'aleventhal+watch@chromium.org', @@ -2221,7 +2210,6 @@ 'jlklein+watch-network@chromium.org', 'khorimoto+watch-network@chromium.org', 'stevenjb+watch-network@chromium.org'], - 'chromeos_power': ['derat+watch@chromium.org'], 'chromeos_timezone': ['alemate+watch@chromium.org'], 'chromeos_webui': ['alemate+watch@chromium.org'], 'chromevox': ['anastasi+watch@google.com'], @@ -2387,7 +2375,6 @@ 'urvang@chromium.org'], 'libxml_xslt': ['ail@google.com', 'dominicc+watchlist@chromium.org'], - 'linux_fonts': ['derat+watch@chromium.org'], 'linux_sandboxing': ['jln+watch@chromium.org'], 'linux_seccomp_bpf': ['jln+watch@chromium.org'], 'mac' : ['mac-reviews@chromium.org'], @@ -2665,8 +2652,7 @@ 'msramek+watch@chromium.org'], 'webui_backend': ['dbeam+watch-webui-backend@chromium.org'], 'windows_sandboxing': ['wfh+watch@chromium.org'], - 'x11': ['derat+watch@chromium.org', - 'sadrul@chromium.org', + 'x11': ['sadrul@chromium.org', 'yusukes+watch@chromium.org'], 'zlib': ['cblume+zlib@chromium.org'], 'zoom': ['wjmaclean@chromium.org'], diff --git a/ash/OWNERS b/ash/OWNERS index 623de272e234b9..f785a7d674d69c 100644 --- a/ash/OWNERS +++ b/ash/OWNERS @@ -1,5 +1,4 @@ afakhry@chromium.org -derat@chromium.org jamescook@chromium.org oshima@chromium.org sky@chromium.org diff --git a/base/i18n/time_formatting.h b/base/i18n/time_formatting.h index dfbfeea6c14904..64b09964466d32 100644 --- a/base/i18n/time_formatting.h +++ b/base/i18n/time_formatting.h @@ -47,10 +47,6 @@ enum DateFormat { DATE_FORMAT_MONTH_WEEKDAY_DAY, }; -// TODO(derat@chromium.org): Update all of these functions to return boolean -// "success" values and use out-params for formatted strings: -// http://crbug.com/698802 - // Returns the time of day, e.g., "3:07 PM". BASE_I18N_EXPORT string16 TimeFormatTimeOfDay(const Time& time); diff --git a/chrome/browser/chromeos/OWNERS b/chrome/browser/chromeos/OWNERS index 3f4dcc4ab4d0a0..41860dd64d1a05 100644 --- a/chrome/browser/chromeos/OWNERS +++ b/chrome/browser/chromeos/OWNERS @@ -4,7 +4,6 @@ per-file BUILD.gn=* achuith@chromium.org alemate@chromium.org -derat@chromium.org jamescook@chromium.org oshima@chromium.org satorux@chromium.org diff --git a/chrome/browser/chromeos/extensions/autotest_private/OWNERS b/chrome/browser/chromeos/extensions/autotest_private/OWNERS index c345b9b7c373af..eb940adeff8634 100644 --- a/chrome/browser/chromeos/extensions/autotest_private/OWNERS +++ b/chrome/browser/chromeos/extensions/autotest_private/OWNERS @@ -1,3 +1,2 @@ achuith@chromium.org -derat@chromium.org stevenjb@chromium.org diff --git a/chrome/browser/chromeos/power/ml/OWNERS b/chrome/browser/chromeos/power/ml/OWNERS index 18f88738d40250..0b16b900ae942d 100644 --- a/chrome/browser/chromeos/power/ml/OWNERS +++ b/chrome/browser/chromeos/power/ml/OWNERS @@ -1,4 +1,3 @@ amoylan@chromium.org -derat@chromium.org jiameng@chromium.org martis@chromium.org diff --git a/chrome/browser/ui/ash/OWNERS b/chrome/browser/ui/ash/OWNERS index 68771a871137ba..54238d967b5dea 100644 --- a/chrome/browser/ui/ash/OWNERS +++ b/chrome/browser/ui/ash/OWNERS @@ -1,4 +1,3 @@ -derat@chromium.org jamescook@chromium.org oshima@chromium.org sky@chromium.org diff --git a/chromeos/OWNERS b/chromeos/OWNERS index 7f5948322103fd..b1fd1cf191bd64 100644 --- a/chromeos/OWNERS +++ b/chromeos/OWNERS @@ -9,7 +9,6 @@ per-file *.xtb=file://tools/translation/TRANSLATION_OWNERS achuith@chromium.org alemate@chromium.org -derat@chromium.org oshima@chromium.org rkc@chromium.org satorux@chromium.org diff --git a/chromeos/dbus/OWNERS b/chromeos/dbus/OWNERS index 54cd6ceb49a40a..c5198cd8410eda 100644 --- a/chromeos/dbus/OWNERS +++ b/chromeos/dbus/OWNERS @@ -1,6 +1,5 @@ stevenjb@chromium.org hashimoto@chromium.org -derat@chromium.org per-file *smb_provider*=amistry@chromium.org per-file *smb_provider*=baileyberro@chromium.org diff --git a/chromeos/dbus/power/OWNERS b/chromeos/dbus/power/OWNERS deleted file mode 100644 index 3c97e54df0299f..00000000000000 --- a/chromeos/dbus/power/OWNERS +++ /dev/null @@ -1 +0,0 @@ -derat@chromium.org diff --git a/components/timers/OWNERS b/components/timers/OWNERS index 0c43483139fb8f..8a3310217a3d07 100644 --- a/components/timers/OWNERS +++ b/components/timers/OWNERS @@ -1,2 +1 @@ chirantan@chromium.org -derat@chromium.org diff --git a/extensions/browser/OWNERS b/extensions/browser/OWNERS index c21998b3e57302..18930777427581 100644 --- a/extensions/browser/OWNERS +++ b/extensions/browser/OWNERS @@ -1,7 +1,6 @@ # Please talk to the apps shell team before adding DEPS. per-file DEPS=set noparent per-file DEPS=benwells@chromium.org -per-file DEPS=derat@chromium.org per-file DEPS=rockot@google.com per-file DEPS=rdevlin.cronin@chromium.org diff --git a/extensions/browser/api/power/OWNERS b/extensions/browser/api/power/OWNERS deleted file mode 100644 index 3c97e54df0299f..00000000000000 --- a/extensions/browser/api/power/OWNERS +++ /dev/null @@ -1 +0,0 @@ -derat@chromium.org diff --git a/services/device/wake_lock/power_save_blocker/OWNERS b/services/device/wake_lock/power_save_blocker/OWNERS index 2fddade429e9bd..fdd793c11186d6 100644 --- a/services/device/wake_lock/power_save_blocker/OWNERS +++ b/services/device/wake_lock/power_save_blocker/OWNERS @@ -1,5 +1,4 @@ boliu@chromium.org hashimoto@chromium.org -per-file power_save_blocker_chromeos.cc=derat@chromium.org # COMPONENT: Internals>Core diff --git a/ui/base/cursor/OWNERS b/ui/base/cursor/OWNERS deleted file mode 100644 index c3e460e44aaeb1..00000000000000 --- a/ui/base/cursor/OWNERS +++ /dev/null @@ -1 +0,0 @@ -per-file *x11*=derat@chromium.org diff --git a/ui/base/x/OWNERS b/ui/base/x/OWNERS index 20cb7078c8fca8..9b39f6f6a216d7 100644 --- a/ui/base/x/OWNERS +++ b/ui/base/x/OWNERS @@ -1,3 +1,3 @@ -davemoore@chromium.org +piman@chromium.org sadrul@chromium.org -derat@chromium.org +thomasanderson@chromium.org diff --git a/ui/chromeos/OWNERS b/ui/chromeos/OWNERS index 94f5eddcd38cff..734b95a3893a8d 100644 --- a/ui/chromeos/OWNERS +++ b/ui/chromeos/OWNERS @@ -1,4 +1,3 @@ -derat@chromium.org jamescook@chromium.org oshima@chromium.org stevenjb@chromium.org diff --git a/ui/display/OWNERS b/ui/display/OWNERS index 0101ef32916a67..6f1361981b8c87 100644 --- a/ui/display/OWNERS +++ b/ui/display/OWNERS @@ -1,5 +1,4 @@ afakhry@chromium.org -derat@chromium.org dnicoara@chromium.org marcheu@chromium.org oshima@chromium.org diff --git a/ui/gfx/OWNERS b/ui/gfx/OWNERS index 077be260cf4600..f764a4527641d8 100644 --- a/ui/gfx/OWNERS +++ b/ui/gfx/OWNERS @@ -12,9 +12,6 @@ per-file color_utils*=pkasting@chromium.org per-file display*=oshima@chromium.org per-file screen*=oshima@chromium.org -# Font-rendering configuration. -per-file font_render_params*=derat@chromium.org - # Canvas painting. per-file canvas*=danakj@chromium.org diff --git a/ui/gfx/test/OWNERS b/ui/gfx/test/OWNERS deleted file mode 100644 index fe470e6c9e0b62..00000000000000 --- a/ui/gfx/test/OWNERS +++ /dev/null @@ -1,2 +0,0 @@ -# Testing support for Linux implementation of FontRenderParams. -per-file fontconfig_util_linux.*=derat@chromium.org diff --git a/ui/gfx/x/OWNERS b/ui/gfx/x/OWNERS index 1b19a9d33fa245..079174d24bce50 100644 --- a/ui/gfx/x/OWNERS +++ b/ui/gfx/x/OWNERS @@ -1,4 +1,4 @@ -derat@chromium.org +thomasanderson@chromium.org # Adding new atoms is allowed without OWNERS review. per-file x11_atom_cache.cc=* diff --git a/ui/wm/core/OWNERS b/ui/wm/core/OWNERS index 37a23e82a2fdd4..5c9931ca5693ec 100644 --- a/ui/wm/core/OWNERS +++ b/ui/wm/core/OWNERS @@ -1,2 +1 @@ -per-file shadow*=derat@chromium.org per-file shadow*=estade@chromium.org