Skip to content

Commit

Permalink
Also pipe stderr git gypv8sh
Browse files Browse the repository at this point in the history
Hopefully stderr contains the actual error message..

R=marja@chromium.org
BUG=370551

Review URL: https://codereview.chromium.org/362303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281049 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jochen@chromium.org committed Jul 2, 2014
1 parent 1d935e6 commit abb2ada
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tools/gypv8sh.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ def main ():
print cmd
if not opts.impotent:
try:
p = subprocess.Popen(cmd, stdout=subprocess.PIPE, bufsize=0)
p = subprocess.Popen(
cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, bufsize=0)
out, err = p.communicate()
if p.returncode:
raise Exception('Failed to run d8', out, err)
Expand Down

0 comments on commit abb2ada

Please sign in to comment.