Skip to content

Commit

Permalink
Revert "RenderProcessHost should have only one active CodeCacheHost i…
Browse files Browse the repository at this point in the history
…nterface"

This reverts commit 4af8319.

Reason for revert: Clusterfuzz issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1217599

Original change's description:
> RenderProcessHost should have only one active CodeCacheHost interface
>
> RenderProcessHost should only have one active CodeCacheHost interface.
> When a RenderProcess dies we reset the CodeCacheHost interface so a new
> one can be requested. Earlier we had a DCHECK asserting that this is
> indeed the case. This CL turns the DCHECK to report a bad message.
>
> Bug: chromium:1213818
> Change-Id: I311367af60e8fcbd468abb7c1c95bb638fbebb08
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2920570
> Reviewed-by: Matt Falkenhagen <falken@chromium.org>
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#889732}

Bug: chromium:1213818
Change-Id: I8a0553c102028e2790fcc1fcd6b3389afbbe3cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2947013
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#890331}
  • Loading branch information
mythrialle authored and Chromium LUCI CQ committed Jun 8, 2021
1 parent fa58d6f commit ab1213e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions content/browser/renderer_host/render_process_host_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2642,9 +2642,7 @@ void RenderProcessHostImpl::CreateCodeCacheHost(

// There should be at most one CodeCacheHostImpl for any given
// RenderProcessHost.
if (!code_cache_host_receivers_.empty()) {
mojo::ReportBadMessage("CodeCacheHost is already bound");
}
DCHECK(code_cache_host_receivers_.empty());

// Create a new CodeCacheHostImpl and bind it to the given receiver.
auto code_cache_host = std::make_unique<CodeCacheHostImpl>(
Expand Down

0 comments on commit ab1213e

Please sign in to comment.