From aab22dde5eb566253a8b20467407a821ac054e33 Mon Sep 17 00:00:00 2001 From: Eric Lawrence Date: Thu, 21 May 2020 01:46:53 +0000 Subject: [PATCH] Fix comments about HTTP2 GREASE Frames MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update two comments about the behavior of the http2-grease-frame-type feature to better describe exactly what it does. Change-Id: I2b5269a3117a499067f111fa25cacd5cc067f0ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209606 Auto-Submit: Eric Lawrence [MSFT] Reviewed-by: Bence Béky Commit-Queue: Bence Béky Cr-Commit-Position: refs/heads/master@{#770892} --- net/http/http_network_session.h | 2 +- net/spdy/spdy_session.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h index 92530037564e68..c39cfddec9a1c0 100644 --- a/net/http/http_network_session.h +++ b/net/http/http_network_session.h @@ -115,7 +115,7 @@ class NET_EXPORT HttpNetworkSession { // logic from hiding broken servers. spdy::SettingsMap http2_settings; // If set, an HTTP/2 frame with a reserved frame type will be sent after - // every HEADERS and SETTINGS frame. See + // every HTTP/2 SETTINGS frame and before every HTTP/2 DATA frame. // https://tools.ietf.org/html/draft-bishop-httpbis-grease-00. // The same frame will be sent out on all connections to prevent the retry // logic from hiding broken servers. diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h index 9c1c504859fa07..c97de37d40e17d 100644 --- a/net/spdy/spdy_session.h +++ b/net/spdy/spdy_session.h @@ -1106,8 +1106,8 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface, // and maximum HPACK dynamic table size. const spdy::SettingsMap initial_settings_; - // If set, an HTTP/2 frame with a reserved frame type will be sent after every - // valid HTTP/2 frame. See + // If set, an HTTP/2 frame with a reserved frame type will be sent after + // every HTTP/2 SETTINGS frame and before every HTTP/2 DATA frame. See // https://tools.ietf.org/html/draft-bishop-httpbis-grease-00. const base::Optional greased_http2_frame_;