Skip to content

Commit

Permalink
Submitting on behalf of jschuh@
Browse files Browse the repository at this point in the history
See http://codereview.chromium.org/307020

Changed active URL handling in RenderView::OnMessageReceived and RenderView::OnNavigate. Now we call SetActiveURL directly so that we don't unset the URL when falling out of scope. 

We can try this in the render process on dev channel for a few weeks. If we're happy with the results, we do the same thing on the plugin process. 


TBR=cpu
BUG=22033
TEST=Trigger a crash in the render process and see if the dump includes the URL

Review URL: http://codereview.chromium.org/328008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29933 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
cevans@chromium.org committed Oct 23, 2009
1 parent 013b4d8 commit a9f607e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions chrome/renderer/render_view.cc
Original file line number Diff line number Diff line change
Expand Up @@ -378,8 +378,8 @@ void RenderView::Init(gfx::NativeViewId parent_hwnd,

void RenderView::OnMessageReceived(const IPC::Message& message) {
WebFrame* main_frame = webview() ? webview()->mainFrame() : NULL;
child_process_logging::ScopedActiveURLSetter url_setter(
main_frame ? main_frame->url() : WebURL());
if (main_frame)
child_process_logging::SetActiveURL(main_frame->url());

// If this is developer tools renderer intercept tools messages first.
if (devtools_client_.get() && devtools_client_->OnMessageReceived(message))
Expand Down Expand Up @@ -715,7 +715,7 @@ void RenderView::OnNavigate(const ViewMsg_Navigate_Params& params) {
if (devtools_agent_.get())
devtools_agent_->OnNavigate();

child_process_logging::ScopedActiveURLSetter url_setter(params.url);
child_process_logging::SetActiveURL(params.url);

AboutHandler::MaybeHandle(params.url);

Expand Down

0 comments on commit a9f607e

Please sign in to comment.