Skip to content

Commit

Permalink
Disable DownloadTestWithHistogramTester.SavePageNonHTMLViaGet on Linu…
Browse files Browse the repository at this point in the history
…x because it's flaky.

TBR=svaldez@chromium.org

Bug: 1028371
Change-Id: I0f084e3263c756bfe59502e359d2dac979efbcee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937658
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#719341}
  • Loading branch information
John Abd-El-Malek authored and Commit Bot committed Nov 26, 2019
1 parent 391dbbe commit a75cfe0
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion chrome/browser/download/download_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2608,7 +2608,14 @@ class DownloadTestWithHistogramTester : public DownloadTest {
std::unique_ptr<URLLoaderInterceptor> url_loader_interceptor_;
};

IN_PROC_BROWSER_TEST_F(DownloadTestWithHistogramTester, SavePageNonHTMLViaGet) {
#if defined(OS_LINUX)
#define MAYBE_SavePageNonHTMLViaGet DISABLED_SavePageNonHTMLViaGet
#else
#define MAYBE_SavePageNonHTMLViaGet SavePageNonHTMLViaGet
#endif

IN_PROC_BROWSER_TEST_F(DownloadTestWithHistogramTester,
MAYBE_SavePageNonHTMLViaGet) {
embedded_test_server()->ServeFilesFromDirectory(GetTestDataDirectory());
ASSERT_TRUE(embedded_test_server()->Start());
EnableFileChooser(true);
Expand Down

0 comments on commit a75cfe0

Please sign in to comment.