diff --git a/AUTHORS b/AUTHORS index 39cf97adcd7052..c8764f756ece91 100644 --- a/AUTHORS +++ b/AUTHORS @@ -96,6 +96,7 @@ Arunprasad Rajkumar Arunprasad Rajkumar Ashish Kumar Gupta Ashlin Joseph +Asish Singh Attila Dusnoki Avinaash Doreswamy Ayush Khandelwal diff --git a/components/autofill/core/browser/credit_card_save_manager_unittest.cc b/components/autofill/core/browser/credit_card_save_manager_unittest.cc index 3ac29d43c3e160..9a206945a7bc54 100644 --- a/components/autofill/core/browser/credit_card_save_manager_unittest.cc +++ b/components/autofill/core/browser/credit_card_save_manager_unittest.cc @@ -74,6 +74,12 @@ std::string NextYear() { return std::to_string(now.year + 1); } +std::string NextMonth() { + base::Time::Exploded now; + base::Time::Now().LocalExplode(&now); + return std::to_string(now.month % 12 + 1); +} + class MockAutofillClient : public TestAutofillClient { public: MockAutofillClient() {} @@ -242,7 +248,7 @@ class CreditCardSaveManagerTest : public testing::Test { // Edit the data, and submit. form.fields[1].value = ASCIIToUTF16("4111111111111111"); - form.fields[2].value = ASCIIToUTF16("11"); + form.fields[2].value = ASCIIToUTF16(NextMonth()); form.fields[3].value = ASCIIToUTF16(NextYear()); EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)); FormSubmitted(form); @@ -376,7 +382,7 @@ TEST_F(CreditCardSaveManagerTest, MAYBE_CreditCardSavedWhenAutocompleteOff) { // Edit the data, and submit. form.fields[1].value = ASCIIToUTF16("4111111111111111"); - form.fields[2].value = ASCIIToUTF16("11"); + form.fields[2].value = ASCIIToUTF16(NextMonth()); form.fields[3].value = ASCIIToUTF16(NextYear()); EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)); FormSubmitted(form); @@ -395,7 +401,7 @@ TEST_F(CreditCardSaveManagerTest, InvalidCreditCardNumberIsNotSaved) { std::string card("4408041234567890"); ASSERT_FALSE(autofill::IsValidCreditCardNumber(ASCIIToUTF16(card))); form.fields[1].value = ASCIIToUTF16(card); - form.fields[2].value = ASCIIToUTF16("11"); + form.fields[2].value = ASCIIToUTF16(NextMonth()); form.fields[3].value = ASCIIToUTF16(NextYear()); EXPECT_CALL(autofill_client_, ConfirmSaveCreditCardLocally(_, _)).Times(0); FormSubmitted(form); @@ -421,7 +427,7 @@ TEST_F(CreditCardSaveManagerTest, CreditCardDisabledDoesNotSave) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -460,7 +466,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -517,7 +523,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_FirstAndLastName) { credit_card_form.fields[0].value = ASCIIToUTF16("Flo"); credit_card_form.fields[1].value = ASCIIToUTF16("Master"); credit_card_form.fields[2].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[3].value = ASCIIToUTF16("11"); + credit_card_form.fields[3].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[4].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[5].value = ASCIIToUTF16("123"); @@ -603,7 +609,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_LastAndFirstName) { credit_card_form.fields[0].value = ASCIIToUTF16("Master"); credit_card_form.fields[1].value = ASCIIToUTF16("Flo"); credit_card_form.fields[2].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[3].value = ASCIIToUTF16("11"); + credit_card_form.fields[3].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[4].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[5].value = ASCIIToUTF16("123"); @@ -664,7 +670,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCardAndSaveCopy) { const char* const card_number = "4111111111111111"; credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16(card_number); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -681,7 +687,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCardAndSaveCopy) { EXPECT_EQ(CreditCard::OK, saved_card->GetServerStatus()); EXPECT_EQ(base::ASCIIToUTF16("1111"), saved_card->LastFourDigits()); EXPECT_EQ(kVisaCard, saved_card->network()); - EXPECT_EQ(11, saved_card->expiration_month()); + EXPECT_EQ(std::stoi(NextMonth()), saved_card->expiration_month()); EXPECT_EQ(std::stoi(NextYear()), saved_card->expiration_year()); EXPECT_EQ(server_id, saved_card->server_id()); EXPECT_EQ(CreditCard::FULL_SERVER_CARD, saved_card->record_type()); @@ -709,7 +715,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_FeatureNotEnabled) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -747,7 +753,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_CvcUnavailable) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // CVC MISSING @@ -788,7 +794,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_CvcInvalidLength) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("1234"); @@ -852,7 +858,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_MultipleCvcFields) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // CVC MISSING credit_card_form.fields[5].value = ASCIIToUTF16("123"); @@ -910,7 +916,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoCvcFieldOnForm) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); base::HistogramTester histogram_tester; @@ -972,7 +978,7 @@ TEST_F(CreditCardSaveManagerTest, // Enter an invalid cvc in "Random Field" and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("1234"); @@ -1035,7 +1041,7 @@ TEST_F(CreditCardSaveManagerTest, // Enter a valid cvc in "Random Field" and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1100,7 +1106,7 @@ TEST_F(CreditCardSaveManagerTest, // Enter a valid cvc in "Random Field" and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1135,7 +1141,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoProfileAvailable) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Bob Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1184,7 +1190,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoRecentlyUsedProfile) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1225,7 +1231,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // CVC MISSING @@ -1269,7 +1275,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoNameAvailable) { // Edit the data, but don't include a name, and submit. credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1304,7 +1310,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, but don't include a name, and submit. credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1359,7 +1365,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_ZipCodesConflict) { // Edit the data and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1410,7 +1416,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1460,7 +1466,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_ZipCodesHavePrefixMatch) { // Edit the data and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1505,7 +1511,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoZipCodeAvailable) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1553,7 +1559,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_CCFormHasMiddleInitial) { // submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo W. Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1595,7 +1601,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NoMiddleInitialInCCForm) { // Edit the data, but do not use middle initial. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1633,7 +1639,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the name by adding a middle name. credit_card_form.fields[0].value = ASCIIToUTF16("John Quincy Adams"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1674,7 +1680,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_CCFormHasAddressMiddleName) { // Edit the name by removing middle name. credit_card_form.fields[0].value = ASCIIToUTF16("John Adams"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1724,7 +1730,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_NamesCanMismatch) { // Edit the data, but use yet another name, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Bob Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1778,7 +1784,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_IgnoreOldProfiles) { // Edit the data, but use yet another name, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Master Blaster"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1820,7 +1826,7 @@ TEST_F( // Edit the data, but don't include a name, and submit. credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1865,7 +1871,7 @@ TEST_F( // Edit the data, but include a conflicting name, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Jane Doe"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1910,7 +1916,7 @@ TEST_F( // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -1958,7 +1964,7 @@ TEST_F( // Edit the data, but don't include a name, and submit. credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2008,7 +2014,7 @@ TEST_F( // Edit the data, but include a conflicting name, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Jane Doe"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2053,7 +2059,7 @@ TEST_F( // Edit the data, but don't include a name, and submit. credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2098,7 +2104,7 @@ TEST_F( // Edit the data, but include a conflicting name, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Jane Doe"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2142,7 +2148,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2195,7 +2201,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_LogPreviousUseDate) { // Edit the credit card form and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2236,7 +2242,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_UploadDetailsFails) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2272,8 +2278,8 @@ TEST_F(CreditCardSaveManagerTest, DuplicateMaskedCreditCard_NoUpload) { // Add a masked credit card whose |TypeAndLastFourDigits| matches what we will // enter below. CreditCard credit_card(CreditCard::MASKED_SERVER_CARD, "a123"); - test::SetCreditCardInfo(&credit_card, "Flo Master", "1111", "11", - NextYear().c_str(), "1"); + test::SetCreditCardInfo(&credit_card, "Flo Master", "1111", + NextMonth().c_str(), NextYear().c_str(), "1"); credit_card.SetNetworkForMaskedCard(kVisaCard); personal_data_.AddServerCreditCard(credit_card); @@ -2285,7 +2291,7 @@ TEST_F(CreditCardSaveManagerTest, DuplicateMaskedCreditCard_NoUpload) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2308,7 +2314,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_NothingIfNothingFound) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2329,7 +2335,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectCvc) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2351,7 +2357,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectCardholderName) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("John Smith"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2379,7 +2385,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectAddressName) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2408,7 +2414,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("John Smith"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2438,7 +2444,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Miles Prower"); // Conflict! credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2465,7 +2471,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectPostalCode) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2498,7 +2504,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2525,7 +2531,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectAddressLine) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2553,7 +2559,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectLocality) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2581,7 +2587,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectAdministrativeArea) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2609,7 +2615,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectCountryCode) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2637,7 +2643,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2670,7 +2676,7 @@ TEST_F(CreditCardSaveManagerTest, GetDetectedValues_DetectEverythingAtOnce) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("John Smith"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2709,7 +2715,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Miles Prower"); // Conflict! credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2757,7 +2763,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name set credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC set @@ -2796,7 +2802,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name! credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC! @@ -2852,7 +2858,7 @@ TEST_F( // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("John Smith"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -2898,7 +2904,7 @@ TEST_F( credit_card_form.fields[0].value = ASCIIToUTF16("John"); credit_card_form.fields[1].value = ASCIIToUTF16("Smith"); credit_card_form.fields[2].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[3].value = ASCIIToUTF16("11"); + credit_card_form.fields[3].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[4].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[5].value = ASCIIToUTF16("123"); @@ -2946,7 +2952,7 @@ TEST_F( // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name! credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC! @@ -2980,7 +2986,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC! @@ -3026,7 +3032,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name! credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -3071,7 +3077,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Miles Prower"); // Conflict! credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -3118,7 +3124,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -3177,7 +3183,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -3223,7 +3229,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16(""); // No name! credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16(""); // No CVC! @@ -3276,7 +3282,7 @@ TEST_F( // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4444333322221111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -3312,7 +3318,7 @@ TEST_F(CreditCardSaveManagerTest, // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -3345,7 +3351,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_AddPanFirstSixToRequest) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4444333322221111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -3371,8 +3377,8 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_UploadOfLocalCard) { // Add a local credit card whose |TypeAndLastFourDigits| matches what we will // enter below. CreditCard local_card; - test::SetCreditCardInfo(&local_card, "Flo Master", "4111111111111111", "11", - NextYear().c_str(), "1"); + test::SetCreditCardInfo(&local_card, "Flo Master", "4111111111111111", + NextMonth().c_str(), NextYear().c_str(), "1"); local_card.set_record_type(CreditCard::LOCAL_CARD); personal_data_.AddCreditCard(local_card); @@ -3395,7 +3401,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_UploadOfLocalCard) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123"); @@ -3440,7 +3446,7 @@ TEST_F(CreditCardSaveManagerTest, UploadCreditCard_UploadOfNewCard) { // Edit the data, and submit. credit_card_form.fields[0].value = ASCIIToUTF16("Flo Master"); credit_card_form.fields[1].value = ASCIIToUTF16("4111111111111111"); - credit_card_form.fields[2].value = ASCIIToUTF16("11"); + credit_card_form.fields[2].value = ASCIIToUTF16(NextMonth()); credit_card_form.fields[3].value = ASCIIToUTF16(NextYear()); credit_card_form.fields[4].value = ASCIIToUTF16("123");