Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Reland Group effects support in cc::AnimationPlayer"
This reverts commit 5978ffa. Reason for revert: Seems to cause failure in linux-chromeos-rel test: telemetry.internal.actions.scroll_unittest.ScrollActionTest.testWheelScrollDistanceWhileZoomed Original change's description: > Reland Group effects support in cc::AnimationPlayer > > Patch https://chromium-review.googlesource.com/c/chromium/src/+/742162 > got reverted because it caused cc_unittest failure on CFI bot. This > patch fixed the bug. > > Commit message from the original patch: > > The current cc/animations logic assumes a single animation has a single > keyframe effect and can only affect a single layer. To enable animations > with multiple keyframe effects, cc::AnimationPlayer need to support > multiple AnimationTickers each corresponding to one keyframe effect. > > Currently there is a 1:1 relationship between AnimationPlayer and > AnimationTicker. This patch is to extend it to 1:n. Here is a summary of > changes: > - Introduce a sub-class of AnimationPlayer, a.k.a > SingleTickerAnimationPlayer, to handle the existing logic (single > effect). SingleTickerAnimationPlayer owns only one AnimationTicker as > the AnimationPlayer does today. > - Currently a AnimationTicker is created upon creating AnimationPlayer. > In this patch, tickers are created separately and added to the player > afterwards. Tickers that the player owns may belong to different targets > therefore the player needs to coordinate with AnimationHost regarding > this situation. > - Adjust existing unit tests according to the changes above. > > Bug: 767043 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: If21bad1285c35bbc048fef6b619c8272c0760551 > Reviewed-on: https://chromium-review.googlesource.com/890724 > Reviewed-by: Ian Vollick <vollick@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532519} TBR=vollick@chromium.org,yigu@chromium.org Change-Id: Ic82337555158a49ec24ae10fb7a6d63db3114828 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767043 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/891998 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#532623}
- Loading branch information