From 9d2349cfc85f8c4be5e57347a47e52e58657f912 Mon Sep 17 00:00:00 2001 From: Sam Maier Date: Thu, 8 Sep 2022 18:52:57 +0000 Subject: [PATCH] Adding additional logging for deobfuscate timeout We've been seeing timeouts but we really don't know why. Hopefully this logging will make it obvious. Bug: 1351023 Change-Id: I8e3d78715cc6c5c8f0f1203b0052414a107b944a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3881005 Commit-Queue: Andrew Grieve Reviewed-by: Andrew Grieve Cr-Commit-Position: refs/heads/main@{#1044687} --- build/android/pylib/symbols/deobfuscator.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/build/android/pylib/symbols/deobfuscator.py b/build/android/pylib/symbols/deobfuscator.py index 48bb057ee02398..a29ddab516d09a 100644 --- a/build/android/pylib/symbols/deobfuscator.py +++ b/build/android/pylib/symbols/deobfuscator.py @@ -110,7 +110,18 @@ def deobfuscate_reader(): 'deobfuscator: Close() called by another thread during join().') return lines if reader_thread.is_alive(): - logging.error('deobfuscator: Timed out.') + logging.error('deobfuscator: Timed out after %f seconds with input:', + timeout) + # We are seeing timeouts but don't know why. Hopefully seeing the + # lines that cause timeouts can make it obvious what the deobfuscator + # is struggling with. + for l in lines: + logging.error(l) + logging.error('deobfuscator: End of timed out input.') + logging.error('deobfuscator: Timed out output was:') + for l in out_lines: + logging.error(l) + logging.error('deobfuscator: End of timed out output.') self.Close() return lines return out_lines