Skip to content

Commit

Permalink
Fix run_test_cases.py to look for gtest test case header.
Browse files Browse the repository at this point in the history
The previous check was wrong and was triggering continuously on browser_tests.

TBR=cmp@chromium.org
NOTRY=true
BUG=
TEST=

Fix detection of no test run


Review URL: https://chromiumcodereview.appspot.com/10796082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147819 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
maruel@chromium.org committed Jul 22, 2012
1 parent 5c719e5 commit 9c9233b
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions tools/isolate/run_test_cases.py
Original file line number Diff line number Diff line change
Expand Up @@ -451,10 +451,9 @@ def map(self, test_case):
'duration': duration,
'output': output,
}
if output.rstrip().endswith('0 tests failed (0 ignored)'):
# Mark it as invalid.
data['invalid'] = True
returncode = 1
if '[ RUN ]' not in output:
# Can't find gtest marker, mark it as invalid.
returncode = returncode or 1
out.append(data)
if sys.platform == 'win32':
output = output.replace('\r\n', '\n')
Expand Down

0 comments on commit 9c9233b

Please sign in to comment.