Skip to content

Commit

Permalink
Reland "Add directory-based CQ for the SKV bot"
Browse files Browse the repository at this point in the history
This reverts commit 24dd823.

Reason for revert: There may be sufficient machine count now.

Original change's description:
> Revert "Add directory-based CQ for the SKV bot"
> 
> This reverts commit 3484418.
> 
> Reason for revert: bot is underprovisioned at current build rate.
> 
> Original change's description:
> > Add directory-based CQ for the SKV bot
> > 
> > The SkiaRenderer Vulkan Android bot was breaking frequently. We
> > want to add it to the CQ for likely-impactful directories. This
> > should help maintain the SKV bot.
> > 
> > Bug: 979431
> > Change-Id: Id332ab4de1b2deac7ad4c53ef8e92351d176b58a
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753667
> > Reviewed-by: Eric Karl <ericrk@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Commit-Queue: Chris Blume <cblume@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#687332}
> 
> TBR=jonross@chromium.org,jbudorick@chromium.org,cblume@chromium.org,ericrk@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 979431
> Change-Id: I1c140d90fd4f4021ac914d12ea63d077d6ec3771
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761309
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#688264}

TBR=jonross@chromium.org,jbudorick@chromium.org,cblume@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 979431
Change-Id: I8651e0f3c9d9c2c0e124d2f1041481f73ba3a583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774903
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691332}
  • Loading branch information
ProgramMax authored and Commit Bot committed Aug 28, 2019
1 parent 54da6c5 commit 9afd42a
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
9 changes: 9 additions & 0 deletions docs/infra/cq_builders.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,15 @@ builder.
Path regular expressions:
* [`//chromecast/.+`](https://cs.chromium.org/chromium/src/chromecast/)

* [gpu-fyi-try-android-p-pixel-2-skv-32](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/gpu-fyi-try-android-p-pixel-2-skv-32) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/gpu-fyi-try-android-p-pixel-2-skv-32)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+gpu-fyi-try-android-p-pixel-2-skv-32))

Path regular expressions:
* [`//components/viz/.+`](https://cs.chromium.org/chromium/src/components/viz/)
* [`//content/test/gpu/gpu_tests/.+py`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:content/test/gpu/gpu_tests/.+py)
* [`//content/test/gpu/gpu_tests/test_expectations/pixel_expectations.txt`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:content/test/gpu/gpu_tests/test_expectations/pixel_expectations.txt)
* [`//gpu/vulkan/.+`](https://cs.chromium.org/chromium/src/gpu/vulkan/)
* [`//services/viz/.+`](https://cs.chromium.org/chromium/src/services/viz/)

* [ios-simulator-cronet](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/ios-simulator-cronet) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/ios-simulator-cronet)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+ios-simulator-cronet))

Path regular expressions:
Expand Down
14 changes: 14 additions & 0 deletions infra/config/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,20 @@ config_groups {
name: "chromium/try/fuchsia-x64-cast"
location_regexp: ".+/[+]/chromecast/.+"
}
builders {
name: "chromium/try/gpu-fyi-try-android-p-pixel-2-skv-32"
# Some locations disabled due to limited capacity.
#location_regexp: ".+/[+]/cc/.+"
location_regexp: ".+/[+]/components/viz/.+"
location_regexp: ".+/[+]/content/test/gpu/gpu_tests/.+py"
location_regexp: ".+/[+]/content/test/gpu/gpu_tests/test_expectations/pixel_expectations.txt"
location_regexp: ".+/[+]/gpu/vulkan/.+"
#location_regexp: ".+/[+]/media/gpu/.+"
location_regexp: ".+/[+]/services/viz/.+"
#location_regexp: ".+/[+]/third_party/blink/renderer/platform/graphics/gpu/.+"
#location_regexp: ".+/[+]/third_party/skia/src/gpu/.+"
#location_regexp: ".+/[+]/third_party/skia/include/gpu/.+"
}
builders {
name: "chromium/try/ios-simulator-cronet"
location_regexp: ".+/[+]/components/cronet/.+"
Expand Down

0 comments on commit 9afd42a

Please sign in to comment.