From 8ed812515bebf00e75d4cdb1e155803f8d4a864c Mon Sep 17 00:00:00 2001 From: Xida Chen Date: Tue, 15 Dec 2020 17:46:19 +0000 Subject: [PATCH] [Code health] Convert base::Bind in gallery_watch_manager_unittest.cc This CL converts three base::Bind to base::BindOnce in this file. The function that takes the callback is already expecting a OnceCallback, so converting to base::BindOnce seems to be the right choice. Bug: 1152278 Change-Id: I0ed76be834d516ccdcb20200b30f172fa41f385a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592012 Reviewed-by: Tommy Li Commit-Queue: Xida Chen Cr-Commit-Position: refs/heads/master@{#837150} --- .../gallery_watch_manager_unittest.cc | 21 +++++++------------ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc b/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc index 13f0c9a39f1ff7..ef4c5438305704 100644 --- a/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc +++ b/chrome/browser/media_galleries/gallery_watch_manager_unittest.cc @@ -159,10 +159,8 @@ class GalleryWatchManagerTest : public GalleryWatchManagerObserver, void AddAndConfirmWatch(MediaGalleryPrefId gallery_id) { base::RunLoop loop; - manager()->AddWatch(profile(), - extension(), - gallery_id, - base::Bind(&ConfirmWatch, base::Unretained(&loop))); + manager()->AddWatch(profile(), extension(), gallery_id, + base::BindOnce(&ConfirmWatch, base::Unretained(&loop))); loop.Run(); } @@ -230,18 +228,13 @@ TEST_F(GalleryWatchManagerTest, MAYBE_Basic) { base::RunLoop loop; if (GalleryWatchesSupported()) { - manager()->AddWatch(profile(), - extension(), - id, - base::Bind(&ConfirmWatch, base::Unretained(&loop))); + manager()->AddWatch(profile(), extension(), id, + base::BindOnce(&ConfirmWatch, base::Unretained(&loop))); } else { manager()->AddWatch( - profile(), - extension(), - id, - base::Bind(&ExpectWatchError, - base::Unretained(&loop), - GalleryWatchManager::kCouldNotWatchGalleryError)); + profile(), extension(), id, + base::BindOnce(&ExpectWatchError, base::Unretained(&loop), + GalleryWatchManager::kCouldNotWatchGalleryError)); } loop.Run(); }