Skip to content

Commit

Permalink
Mojo: Move test_embedder.* to the mojo_system_impl component.
Browse files Browse the repository at this point in the history
Also, tighten up DEPS: things outside mojo/system/ shouldn't include
things in mojo/system/, unless they're an embedder in which case they
can include things in mojo/system/embedder/.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/136473007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245381 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
viettrungluu@chromium.org committed Jan 16, 2014
1 parent cd0f7af commit 8579fe0
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 7 deletions.
1 change: 1 addition & 0 deletions mojo/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ include_rules = [
"+base",
"+build",
"+mojo",
"-mojo/system",
"+mojom",
"+testing",
]
10 changes: 6 additions & 4 deletions mojo/mojo.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,12 @@
'system/waiter.h',
'system/waiter_list.cc',
'system/waiter_list.h',
# Test-only code:
# TODO(vtl): It's a little unfortunate that these end up in the same
# component as non-test-only code. In the static build, this code should
# hopefully be dead-stripped.
'system/embedder/test_embedder.cc',
'system/embedder/test_embedder.h',
],
},
{
Expand All @@ -166,10 +172,6 @@
'system/raw_channel_posix_unittest.cc',
'system/remote_message_pipe_posix_unittest.cc',
'system/simple_dispatcher_unittest.cc',
# TODO(vtl): Move this to mojo_system_impl (and mojo_system_impl's
# exports).
'system/embedder/test_embedder.cc',
'system/embedder/test_embedder.h',
'system/test_utils.cc',
'system/test_utils.h',
'system/waiter_list_unittest.cc',
Expand Down
1 change: 1 addition & 0 deletions mojo/shell/DEPS
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
include_rules = [
"+mojo/system/embedder",
"+net",
"+ui/gl",
]
6 changes: 3 additions & 3 deletions mojo/system/embedder/test_embedder.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,16 @@
#ifndef MOJO_SYSTEM_EMBEDDER_TEST_EMBEDDER_H_
#define MOJO_SYSTEM_EMBEDDER_TEST_EMBEDDER_H_

#include "mojo/system/system_impl_export.h"

namespace mojo {
namespace embedder {
namespace test {

// This shuts down the global, singleton instance. (Note: "Real" embedders are
// not expected to ever shut down this instance. This |Shutdown()| function will
// do more work to ensure that tests don't leak, etc.)
// TODO(vtl): Figure out the library/component/DLL/export situation for test
// embedder stuff. For now, it's linked directly into the unit test binary.
void Shutdown();
MOJO_SYSTEM_IMPL_EXPORT void Shutdown();

} // namespace test
} // namespace embedder
Expand Down

0 comments on commit 8579fe0

Please sign in to comment.