[Code health] Enable gn check for //extensions/browser/api/declarative:*

This CL removes the cyclic dependency between
//extensions/browser/api/declarative_content:* and
//extensions/browser/api/declarative:* by unifying the two targets to
make enabling gn check for
//extensions/browser/api/declarative:* possible.

Bug: 1158942
Change-Id: Ib580c0f6c4a5e6b9eb3bae73d30dbd5f82c340f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2708084
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856541}

.gn

@@ -71,8 +71,6 @@ no_check_targets = [
   "//chrome/browser/storage_access_api:*",  # 2 errors
   "//chrome/browser/touch_to_fill/android:*",  # 8 errors
   "//chrome/test:*",  # 2682 errors
-
-  "//extensions/browser/api/declarative:*",  # 20 errors
   "//extensions/browser/api/declarative_net_request:*",  # 18 errors
   "//extensions/browser/api/declarative_webrequest:*",  # 29 errors
   "//extensions/browser/api/web_request:*",  # 37 errors

extensions/browser/api/BUILD.gn

@@ -110,7 +110,6 @@ group("api_implementations") {
     "//extensions/browser/api/bluetooth_socket",
     "//extensions/browser/api/cast_channel",
     "//extensions/browser/api/declarative",
-    "//extensions/browser/api/declarative_content",
     "//extensions/browser/api/declarative_net_request",
     "//extensions/browser/api/declarative_webrequest",
     "//extensions/browser/api/dns",

extensions/browser/api/declarative/BUILD.gn

@@ -9,6 +9,7 @@ assert(enable_extensions,
 
 source_set("declarative") {
   sources = [
+    "../declarative_content/content_rules_registry.h",
     "declarative_api.cc",
     "declarative_api.h",
     "declarative_rule.h",
@@ -22,7 +23,12 @@ source_set("declarative") {
   ]
 
   deps = [
+    "//components/url_matcher",
     "//content/public/browser",
+    "//extensions/browser/api",
+    "//extensions/browser/api/declarative_webrequest",
+    "//extensions/browser/api/web_request",
+    "//extensions/common",
     "//extensions/common/api",
   ]