Skip to content

Commit

Permalink
[cc] Fix async readback query
Browse files Browse the repository at this point in the history
This was using the incorrect query type and therefore comparing
the results was racy.

BUG=273824

Review URL: https://chromiumcodereview.appspot.com/22901020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218931 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
sievers@chromium.org committed Aug 22, 2013
1 parent ff65d8c commit 751d4c4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cc/output/gl_renderer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2348,7 +2348,7 @@ void GLRenderer::DoGetFramebufferPixels(
if (is_async) {
query = context_->createQueryEXT();
GLC(context_, context_->beginQueryEXT(
GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM,
GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM,
query));
}

Expand Down Expand Up @@ -2389,7 +2389,7 @@ void GLRenderer::DoGetFramebufferPixels(

if (is_async) {
GLC(context_, context_->endQueryEXT(
GL_ASYNC_PIXEL_TRANSFERS_COMPLETED_CHROMIUM));
GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM));
SyncPointHelper::SignalQuery(
context_,
query,
Expand Down

0 comments on commit 751d4c4

Please sign in to comment.