Skip to content

Commit

Permalink
Move SelectionBoundType to inside the LayerSelectionBound message.
Browse files Browse the repository at this point in the history
The SelectionBoundType is only used inside the LayerSelectionBound
proto message, so it should be part of that instead of a top-level
proto, which causes issues with other top-level enums in the same
namespace.

BUG=561210
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1578523002

Cr-Commit-Position: refs/heads/master@{#368781}
  • Loading branch information
tommynyquist authored and Commit bot committed Jan 12, 2016
1 parent cb16922 commit 7500fb4
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
28 changes: 14 additions & 14 deletions cc/input/layer_selection_bound.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,35 @@
namespace cc {
namespace {

proto::SelectionBoundType SelectionBoundTypeToProtobuf(
proto::LayerSelectionBound::SelectionBoundType SelectionBoundTypeToProtobuf(
const SelectionBoundType& type) {
switch (type) {
case SELECTION_BOUND_LEFT:
return proto::SelectionBoundType::LEFT;
return proto::LayerSelectionBound_SelectionBoundType_LEFT;
case SELECTION_BOUND_RIGHT:
return proto::SelectionBoundType::RIGHT;
return proto::LayerSelectionBound_SelectionBoundType_RIGHT;
case SELECTION_BOUND_CENTER:
return proto::SelectionBoundType::CENTER;
return proto::LayerSelectionBound_SelectionBoundType_CENTER;
case SELECTION_BOUND_EMPTY:
return proto::SelectionBoundType::EMPTY;
return proto::LayerSelectionBound_SelectionBoundType_EMPTY;
}
NOTREACHED() << "proto::SelectionBoundType::UNKNOWN";
return proto::SelectionBoundType::UNKNOWN;
NOTREACHED() << "proto::LayerSelectionBound_SelectionBoundType_UNKNOWN";
return proto::LayerSelectionBound_SelectionBoundType_UNKNOWN;
}

SelectionBoundType SelectionBoundTypeFromProtobuf(
const proto::SelectionBoundType& type) {
const proto::LayerSelectionBound::SelectionBoundType& type) {
switch (type) {
case proto::SelectionBoundType::LEFT:
case proto::LayerSelectionBound_SelectionBoundType_LEFT:
return SELECTION_BOUND_LEFT;
case proto::SelectionBoundType::RIGHT:
case proto::LayerSelectionBound_SelectionBoundType_RIGHT:
return SELECTION_BOUND_RIGHT;
case proto::SelectionBoundType::CENTER:
case proto::LayerSelectionBound_SelectionBoundType_CENTER:
return SELECTION_BOUND_CENTER;
case proto::SelectionBoundType::EMPTY:
case proto::LayerSelectionBound_SelectionBoundType_EMPTY:
return SELECTION_BOUND_EMPTY;
case proto::SelectionBoundType::UNKNOWN:
NOTREACHED() << "proto::SelectionBoundType::UNKNOWN";
case proto::LayerSelectionBound_SelectionBoundType_UNKNOWN:
NOTREACHED() << "proto::LayerSelectionBound_SelectionBoundType_UNKNOWN";
return SELECTION_BOUND_EMPTY;
}
return SELECTION_BOUND_EMPTY;
Expand Down
16 changes: 8 additions & 8 deletions cc/proto/layer_selection_bound.proto
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ option optimize_for = LITE_RUNTIME;

package cc.proto;

enum SelectionBoundType {
UNKNOWN = 0;
LEFT = 1;
RIGHT = 2;
CENTER = 3;
EMPTY = 4;
}

message LayerSelectionBound {
enum SelectionBoundType {
UNKNOWN = 0;
LEFT = 1;
RIGHT = 2;
CENTER = 3;
EMPTY = 4;
}

optional SelectionBoundType type = 1;
optional Point edge_top = 2;
optional Point edge_bottom = 3;
Expand Down

0 comments on commit 7500fb4

Please sign in to comment.