From 744e046661f79bb0bb6f01e79cd9f9d9bbfefd19 Mon Sep 17 00:00:00 2001 From: Scott Violet Date: Mon, 19 Aug 2019 23:51:53 +0000 Subject: [PATCH] layout-ng: rename bots to layout_ng_disabled This better indicates that they actually run with layout-ng disabled. BUG=none TEST=none Change-Id: I3b6d916fb1657e3f51fabe106137475c836a347d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754528 Reviewed-by: Dirk Pranke Reviewed-by: Ian Kilpatrick Reviewed-by: Emil A Eklund Commit-Queue: Scott Violet Cr-Commit-Position: refs/heads/master@{#688337} --- docs/infra/cq_builders.md | 2 +- infra/config/commit-queue.cfg | 2 +- infra/config/cr-buildbucket.cfg | 2 +- infra/config/luci-milo.cfg | 4 ++-- testing/buildbot/chromium.fyi.json | 2 +- testing/buildbot/generate_buildbot_json.py | 2 +- testing/buildbot/test_suite_exceptions.pyl | 2 +- testing/buildbot/waterfalls.pyl | 2 +- tools/mb/mb_config.pyl | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) diff --git a/docs/infra/cq_builders.md b/docs/infra/cq_builders.md index 820293a2d8c826..d9f5313ee8f526 100644 --- a/docs/infra/cq_builders.md +++ b/docs/infra/cq_builders.md @@ -219,7 +219,7 @@ builder. * [`//third_party/blink/web_tests/FlagExpectations/enable-blink-features=CompositeAfterPaint`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/FlagExpectations/enable-blink-features=CompositeAfterPaint) * [`//third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/.+`](https://cs.chromium.org/chromium/src/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/) -* [linux_layout_tests_layout_ng](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_layout_tests_layout_ng) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/linux_layout_tests_layout_ng)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_layout_tests_layout_ng)) +* [linux_layout_tests_layout_ng_disabled](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_layout_tests_layout_ng_disabled) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/linux_layout_tests_layout_ng_disabled)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_layout_tests_layout_ng_disabled)) Path regular expressions: * [`//third_party/blink/renderer/core/editing/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/editing/) diff --git a/infra/config/commit-queue.cfg b/infra/config/commit-queue.cfg index 22f84f1dd438f8..ee6239a3fb1845 100644 --- a/infra/config/commit-queue.cfg +++ b/infra/config/commit-queue.cfg @@ -272,7 +272,7 @@ config_groups { location_regexp: ".+/[+]/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/.+" } builders { - name: "chromium/try/linux_layout_tests_layout_ng" + name: "chromium/try/linux_layout_tests_layout_ng_disabled" location_regexp: ".+/[+]/third_party/blink/renderer/core/editing/.+" location_regexp: ".+/[+]/third_party/blink/renderer/core/layout/.+" location_regexp: ".+/[+]/third_party/blink/renderer/core/paint/.+" diff --git a/infra/config/cr-buildbucket.cfg b/infra/config/cr-buildbucket.cfg index 74cef9dff08fa2..0f853821c2cf17 100644 --- a/infra/config/cr-buildbucket.cfg +++ b/infra/config/cr-buildbucket.cfg @@ -4359,7 +4359,7 @@ buckets { } builders { mixins: "linux-try" - name: "linux_layout_tests_layout_ng" + name: "linux_layout_tests_layout_ng_disabled" mixins: "builderless" } builders { diff --git a/infra/config/luci-milo.cfg b/infra/config/luci-milo.cfg index 7cc3dc2dd7d2c1..0d0ffaaaccd61c 100644 --- a/infra/config/luci-milo.cfg +++ b/infra/config/luci-milo.cfg @@ -4365,7 +4365,7 @@ consoles { name: "buildbucket/luci.chromium.try/linux_layout_tests_composite_after_paint" } builders { - name: "buildbucket/luci.chromium.try/linux_layout_tests_layout_ng" + name: "buildbucket/luci.chromium.try/linux_layout_tests_layout_ng_disabled" } builders { name: "buildbucket/luci.chromium.try/linux_mojo" @@ -5108,7 +5108,7 @@ consoles { name: "buildbucket/luci.chromium.try/linux_layout_tests_composite_after_paint" } builders { - name: "buildbucket/luci.chromium.try/linux_layout_tests_layout_ng" + name: "buildbucket/luci.chromium.try/linux_layout_tests_layout_ng_disabled" } builders { name: "buildbucket/luci.chromium.try/linux_mojo" diff --git a/testing/buildbot/chromium.fyi.json b/testing/buildbot/chromium.fyi.json index 051dc973516c46..c75d79a85b7a87 100644 --- a/testing/buildbot/chromium.fyi.json +++ b/testing/buildbot/chromium.fyi.json @@ -1019,7 +1019,7 @@ } ] }, - "WebKit Linux layout_ng Dummy Builder": { + "WebKit Linux layout_ng_disabled Builder": { "gtest_tests": [ { "args": [ diff --git a/testing/buildbot/generate_buildbot_json.py b/testing/buildbot/generate_buildbot_json.py index 035cdcfc4a2c62..c071ad7fd3e4b8 100755 --- a/testing/buildbot/generate_buildbot_json.py +++ b/testing/buildbot/generate_buildbot_json.py @@ -1026,7 +1026,7 @@ def get_bots_that_do_not_actually_exist(self): 'win10-blink-rel-dummy', 'Dummy WebKit Mac10.13', 'WebKit Linux composite_after_paint Dummy Builder', - 'WebKit Linux layout_ng Dummy Builder', + 'WebKit Linux layout_ng_disabled Builder', # chromium, due to https://crbug.com/878915 'win-dbg', 'win32-dbg', diff --git a/testing/buildbot/test_suite_exceptions.pyl b/testing/buildbot/test_suite_exceptions.pyl index 98a7ecf149afd0..22712e15372046 100644 --- a/testing/buildbot/test_suite_exceptions.pyl +++ b/testing/buildbot/test_suite_exceptions.pyl @@ -1859,7 +1859,7 @@ '--additional-driver-flag=--enable-blink-features=CompositeAfterPaint', ], }, - 'WebKit Linux layout_ng Dummy Builder': { + 'WebKit Linux layout_ng_disabled Builder': { 'args': [ '--additional-driver-flag=--disable-blink-features=LayoutNG', ], diff --git a/testing/buildbot/waterfalls.pyl b/testing/buildbot/waterfalls.pyl index d811f819041bc5..8c27157811930f 100644 --- a/testing/buildbot/waterfalls.pyl +++ b/testing/buildbot/waterfalls.pyl @@ -1440,7 +1440,7 @@ 'isolated_scripts': 'chromium_webkit_isolated_scripts', }, }, - 'WebKit Linux layout_ng Dummy Builder': { + 'WebKit Linux layout_ng_disabled Builder': { 'mixins': [ 'linux-xenial', ], diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl index d61e86191d4f49..0aa706336b6e5a 100644 --- a/tools/mb/mb_config.pyl +++ b/tools/mb/mb_config.pyl @@ -777,7 +777,7 @@ 'linux_chromium_ubsan_rel_ng': 'ubsan_vptr_release_bot', 'linux_layout_tests_composite_after_paint': 'release_trybot', - 'linux_layout_tests_layout_ng': 'release_trybot', + 'linux_layout_tests_layout_ng_disabled': 'release_trybot', 'linux_mojo': 'release_trybot', 'linux_mojo_chromeos': 'chromeos_with_codecs_release_trybot', 'linux_optional_gpu_tests_rel': 'gpu_fyi_tests_release_trybot',