Skip to content

Commit

Permalink
layout-ng: rename bots to layout_ng_disabled
Browse files Browse the repository at this point in the history
This better indicates that they actually run with layout-ng disabled.

BUG=none
TEST=none

Change-Id: I3b6d916fb1657e3f51fabe106137475c836a347d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754528
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688337}
  • Loading branch information
Scott Violet authored and Commit Bot committed Aug 19, 2019
1 parent d893e41 commit 744e046
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion docs/infra/cq_builders.md
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ builder.
* [`//third_party/blink/web_tests/FlagExpectations/enable-blink-features=CompositeAfterPaint`](https://cs.chromium.org/search/?q=package:%5Echromium$+file:third_party/blink/web_tests/FlagExpectations/enable-blink-features=CompositeAfterPaint)
* [`//third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/.+`](https://cs.chromium.org/chromium/src/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/)

* [linux_layout_tests_layout_ng](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_layout_tests_layout_ng) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/linux_layout_tests_layout_ng)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_layout_tests_layout_ng))
* [linux_layout_tests_layout_ng_disabled](https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_layout_tests_layout_ng_disabled) ([`commit-queue.cfg` entry](https://cs.chromium.org/search/?q=package:%5Echromium$+file:commit-queue.cfg+chromium/try/linux_layout_tests_layout_ng_disabled)) ([matching builders](https://cs.chromium.org/search/?q=file:trybots.py+linux_layout_tests_layout_ng_disabled))

Path regular expressions:
* [`//third_party/blink/renderer/core/editing/.+`](https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/editing/)
Expand Down
2 changes: 1 addition & 1 deletion infra/config/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ config_groups {
location_regexp: ".+/[+]/third_party/blink/web_tests/flag-specific/enable-blink-features=CompositeAfterPaint/.+"
}
builders {
name: "chromium/try/linux_layout_tests_layout_ng"
name: "chromium/try/linux_layout_tests_layout_ng_disabled"
location_regexp: ".+/[+]/third_party/blink/renderer/core/editing/.+"
location_regexp: ".+/[+]/third_party/blink/renderer/core/layout/.+"
location_regexp: ".+/[+]/third_party/blink/renderer/core/paint/.+"
Expand Down
2 changes: 1 addition & 1 deletion infra/config/cr-buildbucket.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4359,7 +4359,7 @@ buckets {
}
builders {
mixins: "linux-try"
name: "linux_layout_tests_layout_ng"
name: "linux_layout_tests_layout_ng_disabled"
mixins: "builderless"
}
builders {
Expand Down
4 changes: 2 additions & 2 deletions infra/config/luci-milo.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4365,7 +4365,7 @@ consoles {
name: "buildbucket/luci.chromium.try/linux_layout_tests_composite_after_paint"
}
builders {
name: "buildbucket/luci.chromium.try/linux_layout_tests_layout_ng"
name: "buildbucket/luci.chromium.try/linux_layout_tests_layout_ng_disabled"
}
builders {
name: "buildbucket/luci.chromium.try/linux_mojo"
Expand Down Expand Up @@ -5108,7 +5108,7 @@ consoles {
name: "buildbucket/luci.chromium.try/linux_layout_tests_composite_after_paint"
}
builders {
name: "buildbucket/luci.chromium.try/linux_layout_tests_layout_ng"
name: "buildbucket/luci.chromium.try/linux_layout_tests_layout_ng_disabled"
}
builders {
name: "buildbucket/luci.chromium.try/linux_mojo"
Expand Down
2 changes: 1 addition & 1 deletion testing/buildbot/chromium.fyi.json
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,7 @@
}
]
},
"WebKit Linux layout_ng Dummy Builder": {
"WebKit Linux layout_ng_disabled Builder": {
"gtest_tests": [
{
"args": [
Expand Down
2 changes: 1 addition & 1 deletion testing/buildbot/generate_buildbot_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -1026,7 +1026,7 @@ def get_bots_that_do_not_actually_exist(self):
'win10-blink-rel-dummy',
'Dummy WebKit Mac10.13',
'WebKit Linux composite_after_paint Dummy Builder',
'WebKit Linux layout_ng Dummy Builder',
'WebKit Linux layout_ng_disabled Builder',
# chromium, due to https://crbug.com/878915
'win-dbg',
'win32-dbg',
Expand Down
2 changes: 1 addition & 1 deletion testing/buildbot/test_suite_exceptions.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -1859,7 +1859,7 @@
'--additional-driver-flag=--enable-blink-features=CompositeAfterPaint',
],
},
'WebKit Linux layout_ng Dummy Builder': {
'WebKit Linux layout_ng_disabled Builder': {
'args': [
'--additional-driver-flag=--disable-blink-features=LayoutNG',
],
Expand Down
2 changes: 1 addition & 1 deletion testing/buildbot/waterfalls.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -1440,7 +1440,7 @@
'isolated_scripts': 'chromium_webkit_isolated_scripts',
},
},
'WebKit Linux layout_ng Dummy Builder': {
'WebKit Linux layout_ng_disabled Builder': {
'mixins': [
'linux-xenial',
],
Expand Down
2 changes: 1 addition & 1 deletion tools/mb/mb_config.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@
'linux_chromium_ubsan_rel_ng': 'ubsan_vptr_release_bot',

'linux_layout_tests_composite_after_paint': 'release_trybot',
'linux_layout_tests_layout_ng': 'release_trybot',
'linux_layout_tests_layout_ng_disabled': 'release_trybot',
'linux_mojo': 'release_trybot',
'linux_mojo_chromeos': 'chromeos_with_codecs_release_trybot',
'linux_optional_gpu_tests_rel': 'gpu_fyi_tests_release_trybot',
Expand Down

0 comments on commit 744e046

Please sign in to comment.