Settings WebUI: hide tap highlight while expanding advanced section

Bug: 1061333 Change-Id: I33f1f46d4e7b64ee7ed77e7158ee4a3a77986037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159695 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#761513}
marcosholgado · Apr 22, 2020 · 70344df · 70344df
1 parent 4aa0f19
commit 70344df
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html
@@ -5,6 +5,10 @@
         overflow: hidden;
       }
 
+      :host([advanced-toggling-in-progress_]) {
+        -webkit-tap-highlight-color: transparent;
+      }
+
       #advancedToggle {
         --ink-color: currentColor;
         align-items: center;

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -130,6 +130,16 @@ Polymer({
 
     /** @private {!Route|undefined} */
     currentRoute_: Object,
+
+    /**
+     * Used to avoid handling a new toggle while currently toggling.
+     * @private
+     */
+    advancedTogglingInProgress_: {
+      type: Boolean,
+      value: false,
+      reflectToAttribute: true,
+    },
   },
 
   hostAttributes: {
@@ -140,12 +150,6 @@ Polymer({
     'subpage-expand': 'onSubpageExpanded_',
   },
 
-  /**
-   * Used to avoid handling a new toggle while currently toggling.
-   * @private {boolean}
-   */
-  advancedTogglingInProgress_: false,
-
   // <if expr="chromeos">
   /** @private {boolean} */
   osBannerShowMetricRecorded_: false,