Skip to content

Commit

Permalink
[sql] Drop sqlite3_* proxy hacks.
Browse files Browse the repository at this point in the history
Now that sqlite is a shlib under component build, the hacks to proxy
functions are not necessary.

BUG=489444
TBR=michaeln@chromium.org

Review URL: https://codereview.chromium.org/1303423009

Cr-Commit-Position: refs/heads/master@{#346994}
  • Loading branch information
dshess authored and Commit bot committed Sep 2, 2015
1 parent 82c93e1 commit 6ce9d1f
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 78 deletions.
2 changes: 0 additions & 2 deletions sql/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ component("sql") {
"init_status.h",
"meta_table.cc",
"meta_table.h",
"proxy.cc",
"proxy.h",
"recovery.cc",
"recovery.h",
"statement.cc",
Expand Down
13 changes: 6 additions & 7 deletions sql/connection_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#include "sql/connection.h"
#include "sql/correct_sql_test_base.h"
#include "sql/meta_table.h"
#include "sql/proxy.h"
#include "sql/statement.h"
#include "sql/test/error_callback_support.h"
#include "sql/test/scoped_error_ignorer.h"
Expand Down Expand Up @@ -86,12 +85,12 @@ class ScopedScalarFunction {
int args,
base::Callback<void(sqlite3_context*,int,sqlite3_value**)> cb)
: db_(db.db_), function_name_(function_name), cb_(cb) {
sql::sqlite3_create_function_v2(db_, function_name, args, SQLITE_UTF8,
this, &Run, NULL, NULL, NULL);
sqlite3_create_function_v2(db_, function_name, args, SQLITE_UTF8,
this, &Run, NULL, NULL, NULL);
}
~ScopedScalarFunction() {
sql::sqlite3_create_function_v2(db_, function_name_, 0, SQLITE_UTF8,
NULL, NULL, NULL, NULL, NULL);
sqlite3_create_function_v2(db_, function_name_, 0, SQLITE_UTF8,
NULL, NULL, NULL, NULL, NULL);
}

private:
Expand All @@ -115,10 +114,10 @@ class ScopedCommitHook {
base::Callback<int(void)> cb)
: db_(db.db_),
cb_(cb) {
sql::sqlite3_commit_hook(db_, &Run, this);
sqlite3_commit_hook(db_, &Run, this);
}
~ScopedCommitHook() {
sql::sqlite3_commit_hook(db_, NULL, NULL);
sqlite3_commit_hook(db_, NULL, NULL);
}

private:
Expand Down
28 changes: 0 additions & 28 deletions sql/proxy.cc

This file was deleted.

39 changes: 0 additions & 39 deletions sql/proxy.h

This file was deleted.

2 changes: 0 additions & 2 deletions sql/sql.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@
'init_status.h',
'meta_table.cc',
'meta_table.h',
'proxy.cc',
'proxy.h',
'recovery.cc',
'recovery.h',
'statement.cc',
Expand Down

0 comments on commit 6ce9d1f

Please sign in to comment.