Remove base/optional.md and mentions of Optional in docs/

Bug: 1202909 Change-Id: I99d03e5cc1ec9fe1108d9688b97043b97ab3fcac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2912793 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#885750}
marcosholgado · May 22, 2021 · 65fe22a · 65fe22a
1 parent 478da6d
commit 65fe22a
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 123 deletions.
diff --git a/docs/README.md b/docs/README.md
@@ -134,7 +134,6 @@ used when committed.
     Visualizing view trees during debugging
 *   [Bitmap Pipeline](bitmap_pipeline.md) - How bitmaps are moved from the
     renderer to the screen.
-*   [base::Optional](optional.md) - How to use `base::Optional` in C++ code.
 *   [Using the Origin Trials Framework](origin_trials_integration.md) - A
     framework for conditionally enabling experimental APIs for testing.
 *   [`ClientTagBasedModelTypeProcessor` in Unified Sync and Storage](sync/uss/client_tag_based_model_type_processor.md) -

diff --git a/docs/optional.md b/docs/optional.md
diff --git a/docs/sync/model_api.md b/docs/sync/model_api.md
@@ -183,7 +183,7 @@ local state.
 Here’s an example implementation of a type using `ModelTypeStore`:
 
 ```cpp
-base::Optional<ModelError> DeviceInfoSyncBridge::ApplySyncChanges(
+absl::optional<ModelError> DeviceInfoSyncBridge::ApplySyncChanges(
     std::unique_ptr<MetadataChangeList> metadata_change_list,
     EntityChangeList entity_changes) {
   std::unique_ptr<WriteBatch> batch = store_->CreateWriteBatch();

diff --git a/docs/ui/learn/bestpractices/colors.md b/docs/ui/learn/bestpractices/colors.md
@@ -474,7 +474,7 @@ SkColor GetAuraColor(
           NativeTheme::kColorId_ButtonColor,
           color_scheme);
       return color_utils::BlendForMinContrast(
-          bg, bg, base::nullopt, 1.2f).color;
+          bg, bg, absl::nullopt, 1.2f).color;
     }
     ...
   }

diff --git a/docs/ui/learn/bestpractices/layout.md b/docs/ui/learn/bestpractices/layout.md
@@ -279,7 +279,7 @@ TabGroupEditorBubbleView::TabGroupEditorBubbleView(
     const Browser* browser,
     const tab_groups::TabGroupId& group,
     TabGroupHeader* anchor_view,
-    base::Optional<gfx::Rect> anchor_rect,
+    absl::optional<gfx::Rect> anchor_rect,
     bool stop_context_menu_propagation)
     : ... {
 
@@ -374,7 +374,7 @@ TabGroupEditorBubbleView::TabGroupEditorBubbleView(
     const Browser* browser,
     const tab_groups::TabGroupId& group,
     views::View* anchor_view,
-    base::Optional<gfx::Rect> anchor_rect,
+    absl::optional<gfx::Rect> anchor_rect,
     TabGroupHeader* header_view,
     bool stop_context_menu_propagation)
     : ... {

diff --git a/docs/ui/views/metadata_properties.md b/docs/ui/views/metadata_properties.md
@@ -180,7 +180,7 @@ at run-time, getting or setting the value directly via the getter and setter is
 perfectly valid.
 
 The type converter for a non-serializable type may return something from the
-ToString() method, but it will typically return base::nullopt from the
+ToString() method, but it will typically return absl::nullopt from the
 FromString() method. For a non-serializable type, the ui-devtools front-end
 won’t call the setter since whatever “value” it has is presumed to be
 unconvertable to a valid value.