From 6400540a9534d8d299405f7944bf8927c1aec43b Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Wed, 16 Oct 2019 01:32:59 +0000 Subject: [PATCH] Revert "ipc: disable AFDO on Linux" This reverts commit af31b7d5a7c5c831c65a418ae305a4aad520ceea. The problem bit us again in crbug.com/1005023, so I implemented a more general fix. As a result, we should now be safe to turn AFDO back on here. Bug: 916130 Change-Id: I0f29059f9eccaf62dfeeccf543a8cabbeeaf86a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860881 Reviewed-by: Ken Rockot Commit-Queue: George Burgess Cr-Commit-Position: refs/heads/master@{#706266} --- ipc/BUILD.gn | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/ipc/BUILD.gn b/ipc/BUILD.gn index 50127fcd855e3a..1bf3d501201004 100644 --- a/ipc/BUILD.gn +++ b/ipc/BUILD.gn @@ -104,16 +104,6 @@ component("ipc") { "//base", ] - # TODO(https://crbug.com/916130): AFDO causes a substantial size increase in - # nacl_helper that originates from here. This is apparently due to some - # mixture of inlining, CFI, and (potentially) speculative devirtualization. - # Work around that by locally disabling AFDO. - # - # nacl_helper is only available on Linux. - if (is_linux) { - configs -= [ "//build/config/compiler:afdo" ] - } - if (enable_ipc_fuzzer) { public_configs = [ "//tools/ipc_fuzzer:ipc_fuzzer_config" ] }