diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc index 432b886d407696..12e67b7c8ddff1 100644 --- a/chrome/browser/about_flags.cc +++ b/chrome/browser/about_flags.cc @@ -3469,6 +3469,11 @@ const FeatureEntry kFeatureEntries[] = { flag_descriptions::kDesktopPWAsFlashAppNameInsteadOfOriginDescription, kOsDesktop, FEATURE_VALUE_TYPE(features::kDesktopPWAsFlashAppNameInsteadOfOrigin)}, + {"enable-desktop-pwas-notification-icon-and-title", + flag_descriptions::kDesktopPWAsNotificationIconAndTitleName, + flag_descriptions::kDesktopPWAsNotificationIconAndTitleDescription, + kOsDesktop, + FEATURE_VALUE_TYPE(features::kDesktopPWAsNotificationIconAndTitle)}, {"enable-desktop-pwas-tab-strip", flag_descriptions::kDesktopPWAsTabStripName, flag_descriptions::kDesktopPWAsTabStripDescription, kOsDesktop, diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json index dd71927409cb43..e6035acd892978 100644 --- a/chrome/browser/flag-metadata.json +++ b/chrome/browser/flag-metadata.json @@ -1665,6 +1665,11 @@ "owners": [ "alancutter@chromium.org", "desktop-pwas-team@google.com" ], "expiry_milestone": 96 }, + { + "name": "enable-desktop-pwas-notification-icon-and-title", + "owners": [ "loyso@chromium.org", "desktop-pwas-team@google.com" ], + "expiry_milestone": 98 + }, { "name": "enable-desktop-pwas-protocol-handling", "owners": [ "samtan@microsoft.com", "desktop-pwas-team@google.com" ], diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc index 743c0969268997..69d7b471e1e643 100644 --- a/chrome/browser/flag_descriptions.cc +++ b/chrome/browser/flag_descriptions.cc @@ -753,6 +753,12 @@ const char kDesktopPWAsFlashAppNameInsteadOfOriginDescription[] = "Replaces the origin flash with an app name flash when launching a web app " "window."; +const char kDesktopPWAsNotificationIconAndTitleName[] = + "Desktop PWAs improvements in notification icon and title"; +const char kDesktopPWAsNotificationIconAndTitleDescription[] = + "Replaces the websites origin and the Chrome icon with the web app's name " + "and app icon in notifications."; + const char kDesktopPWAsLinkCapturingName[] = "Desktop PWA declarative link capturing"; const char kDesktopPWAsLinkCapturingDescription[] = diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h index 93156d2c12ec3f..431ae3d6f8605f 100644 --- a/chrome/browser/flag_descriptions.h +++ b/chrome/browser/flag_descriptions.h @@ -459,6 +459,9 @@ extern const char kDesktopPWAsElidedExtensionsMenuDescription[]; extern const char kDesktopPWAsFlashAppNameInsteadOfOriginName[]; extern const char kDesktopPWAsFlashAppNameInsteadOfOriginDescription[]; +extern const char kDesktopPWAsNotificationIconAndTitleName[]; +extern const char kDesktopPWAsNotificationIconAndTitleDescription[]; + extern const char kDesktopPWAsLinkCapturingName[]; extern const char kDesktopPWAsLinkCapturingDescription[]; diff --git a/chrome/common/chrome_features.cc b/chrome/common/chrome_features.cc index 46fa4f2ff9461b..29b90e0ae81b75 100644 --- a/chrome/common/chrome_features.cc +++ b/chrome/common/chrome_features.cc @@ -285,6 +285,11 @@ const base::Feature kDesktopPWAsFlashAppNameInsteadOfOrigin{ "DesktopPWAsFlashAppNameInsteadOfOrigin", base::FEATURE_DISABLED_BY_DEFAULT}; +// Replaces the origin text flash and the icon in web app notifications with +// the name of the app and the icon of the app. +const base::Feature kDesktopPWAsNotificationIconAndTitle{ + "DesktopPWAsNotificationIconAndTitle", base::FEATURE_DISABLED_BY_DEFAULT}; + // Enables or disables Desktop PWAs to be auto-started on OS login. const base::Feature kDesktopPWAsRunOnOsLogin { "DesktopPWAsRunOnOsLogin", diff --git a/chrome/common/chrome_features.h b/chrome/common/chrome_features.h index d5fa5e41b48d1d..37c244c174dc70 100644 --- a/chrome/common/chrome_features.h +++ b/chrome/common/chrome_features.h @@ -199,6 +199,9 @@ extern const base::Feature kDesktopPWAsElidedExtensionsMenu; COMPONENT_EXPORT(CHROME_FEATURES) extern const base::Feature kDesktopPWAsFlashAppNameInsteadOfOrigin; +COMPONENT_EXPORT(CHROME_FEATURES) +extern const base::Feature kDesktopPWAsNotificationIconAndTitle; + COMPONENT_EXPORT(CHROME_FEATURES) extern const base::Feature kDesktopPWAsRunOnOsLogin; diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml index 8709a915d76b13..4ddc2202038759 100644 --- a/tools/metrics/histograms/enums.xml +++ b/tools/metrics/histograms/enums.xml @@ -45747,6 +45747,7 @@ from previous Chrome versions. + @@ -46912,6 +46913,7 @@ from previous Chrome versions. label="HappinessTrackingSurveysForDesktopDevToolsIssuesCookiesSameSite:enabled"/> +