Cleanup: Don't check for negative values from EVP_DigestVerifyFinal.

(No longer a possibility in BoringSSL). Review URL: https://codereview.chromium.org/707973007 Cr-Commit-Position: refs/heads/master@{#303700}
marcosholgado · Nov 11, 2014 · 5a49bc9 · 5a49bc9
1 parent 9b199fa
commit 5a49bc9
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/crypto/signature_verifier_openssl.cc b/crypto/signature_verifier_openssl.cc
@@ -122,8 +122,7 @@ bool SignatureVerifier::VerifyFinal() {
   int rv = EVP_DigestVerifyFinal(verify_context_->ctx.get(),
                                  vector_as_array(&signature_),
                                  signature_.size());
-  // rv is -1 if a DER-encoded ECDSA signature cannot be decoded correctly.
-  DCHECK_GE(rv, -1);
+  DCHECK_EQ(!!rv, rv);
   Reset();
   return rv == 1;
 }